Gitea: Update go-macaron/cache and go-macaron/session

Created on 30 Jul 2019  路  10Comments  路  Source: go-gitea/gitea

I would like to update the go-macaron/cache and go-macaron/session packages to use the latest version of go-redis client. The latest client has support for Redis cluster. I opened prs against the macaron repos for 2 months which have not been merged.

How can gitea use my updated version of the macaron libraries?

picture tamalsaha

All 10 comments

There has been some discussion on switching away from macaron due to several issues, one of which you mentioned (pending PRs not being merged for >2mos). The issue is #7403.

I think while we work on the above, we may need to fork macaron in the interim so we can add fixes, such as the ones above. Maybe we create a new org on gitea.com (we'd need to rename macaron to something else) with the macaron repos in it that Gitea project can maintain itself.

@lunny @zeripath thoughts?

techknowlogick picture techknowlogick on 30 Jul 2019
👍1

I suggest we convert to gin web framework and we can maintain some gin's middlewares. I think we can do something on v1.10 and v1.11

lunny picture lunny on 30 Jul 2019
🚀1

I like gin, but that will take time to convert. I think short-term fork of macaron would be good while we wait for #7403

techknowlogick picture techknowlogick on 30 Jul 2019

For a short-term target, I like your idea to create a new org in gitea.com to fork macaron's repositories.

lunny picture lunny on 31 Jul 2019
👍1

I also agree with maintaining forked repos for now.

tamalsaha picture tamalsaha on 31 Jul 2019

I have created fork organization https://gitea.com/macaron and I think we can move some gitea internal middlewares to that organization

lunny picture lunny on 31 Jul 2019

@techknowlogick / @lunny / @zeripath , it seems that the following macaron repos should be forked too, since the main macaron repo has been forked.

  • github.com/go-macaron/binding
  • github.com/go-macaron/cors
  • github.com/go-macaron/i18n
  • github.com/go-macaron/inject
  • github.com/go-macaron/toolbox
tamalsaha picture tamalsaha on 1 Aug 2019

All above forked, but need PRs.

lunny picture lunny on 2 Aug 2019

@lunny , can you please add drone for the repos? I can send pr for the go.mod stuff.

tamalsaha picture tamalsaha on 2 Aug 2019

@tamalsaha all drone added.

lunny picture lunny on 3 Aug 2019
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

adpande picture adpande  路  3Comments
jonasfranz picture jonasfranz  路  3Comments
thehowl picture thehowl  路  3Comments
lunny picture lunny  路  3Comments
flozz picture flozz  路  3Comments