Gitea: [Branch View] [Bug] Restore Branch Button dont work

[6543]

The Restore Branch Button dont work on Firefox (Linux/68.0.1 x64)

testet on Gitea 1.10

[6543]

@lunny please add the kind/bug label so i can rename the issue name

[6543]

http://localhost:3000/test/hometest/branches/restore?branch_id=22&name=merge-calcle produce page 404
is api brocken? (tested on firefox and chrome)

url was taken from "data-url" atribute of undo-button

[techknowlogick]

It may 404 for GET requests, I believe it only accepts POST

[lunny]

Cannot reproduce on macOS Chrome and Firefox.

[6543]

I'll test it on Windows and two different Linux systems today ...

EDIT: two diff Windows too

[6543]

Version: 1.10.0+dev-210-gc9546d4cd

System | Browser | Worked | Didn't
----------- | ------------ | ----------- | --------
5.2.8-1-MANJARO | Chrome 76 (64-Bit) | x |
5.2.8-1-MANJARO | Chromium 76 (64-Bit) | x |
5.2.8-1-MANJARO | Falkon 3.1.0 (QtWebEngine 5.13.0) | x |
5.2.8-1-MANJARO | Firefox 68.0.1 (64-Bit) | | x
5.2.8-1-MANJARO | Firefox Developer Ed. 69.0b12 (64-Bit) | | x
4.18.0-25-lowlatency Ubuntu Cosmic | Firefox 68.0 (64-Bit) | | x
4.18.0-25-lowlatency Ubuntu Cosmic | Chrome73 (64-Bit) |x|
Windows 8.1 Pro | Firefox 62.0.3 (64-Bit) |x|
Windows 8.1 Pro | Firefox 68.0.2 (64-Bit) |x|
Windows 10 Pro N | Firefox 67.0.2 (64-Bit) | |x
Windows 10 Pro N | Firefox 68.0.2 (64-Bit) | x |
Windows 10 Pro N | Edge 42 | x |
Android 9 | Fennec F-Droid 68.0 | | x
Android 9 | Tor Browser 60.8.0 | | x
Android 9 | Lightning 4.5.1 | x |

[6543]

so only Firefox Linux versions and one Windows Firefox combi has problems with this :(

-> cant test Max OSX so if somebody can do this ...

EDIT: @lunny can you add detailed information of your OSX test?

[6543]

it realy looks like Linux + Firefox dont open the link as POST but as GET request!

[lunny]

System | Browser | Worked | Didn't
----------- | ------------ | ----------- | --------
macOS 10.14.5 | Chrome 76 (64-Bit) | x |
macOS 10.14.5 | Firefox 68 (64-Bit) | x |
macOS 10.14.5 | Safari 12.1.1 (64-Bit) | x |

[6543]

tested with current version https://github.com/go-gitea/gitea/commit/8a828500e689b7958e050ebd2dc46d380c3d6ae6

System: Linux 5.2 | Manjaro | Firefox 69.0.1 (64-Bit)

result: still exist

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[6543]

tested with e80fe201c0e7b1f7a73aa932d4a02068e044f0ce still exist :(

[6543]

gone with fomantic :+1: