Gitea: Cross Repo Issue Dependencies

[jag3773]

Description

As a follow on to https://github.com/go-gitea/gitea/pull/2531, it would be excellent if this could be extended to allow cross repo dependencies. Being able to link across different projects would be a powerful way to model dependencies between projects.

Use case: as a project manager I want to be able to create a dependency between issues in different projects (repos). For example, I may have an API codebase in a separate repo than a UI codebase. I have a feature request to add something to the UI that depends on building the API component first.

Implementation Notes

I wouldn't want the suggestion list to explode to any possible issue on a server but it would seem reasonable to suggest issues that the user has recently visited (Trello uses this method in their attachment UI). However, even without that, simply being able to paste in any issue URL would be acceptable functionality (for me).

[bhalbright]

Hello, just wanted to post that I am working on this in a fork. I haven't pushed any changes up yet but changing to query across repos that the user has access to seems straightforward, but some of the things that fall out afterwards require some thought. For example, when a user looks at an issue with a dependency to an issue in another repo that they can't access, what do they see? Also I think the view in the search to add a dependency (and the list of dependencies) should indicate what repo the issue originated from (like possibly show the repo's avatar). Anyway, any thoughts please let me know, thanks!

[lunny]

Users who have read permission of issues units on both repositories could do a reference.

[jag3773]

Somewhat related, probably using GitHub's org/repo#1234 syntax would be good for showing and maybe even typing in relations (in addition to straight urls).

For example, this issue is go-gitea/gitea#7405 (go-gitea/gitea#7405).

This regex (?P<org>[a-zA-Z0-9_-]+)/(?P<repo>[a-zA-Z0-9_-]+)#(?P<id>[0-9]+) should map into https://example.com/%(org)s/%(repo)s/issues/%(id)s.

[bhalbright]

Thoughts on this layout of showing the dependencies? This is the same as how the issues are displayed on the issues page at http:///issues. Plus I think this is the same or similar to @jag3733's suggestion

[guillep2k]

The gray button style looks very much like topics do (those are not bold, though). What about something like this?:

I think that it's useful that the color palette is the same as for "normal" issues.

In my company repository names are much longer than "repo2", though. For example, "lib-comunicaciones" or "ProductDesignNotes". I don't know how would that look. Another possibility is to use only the issue number and leave some visual indication that the issue is not local (e.g. instead of #236 use #235*) and use some kind of mouseover tooltip for the full repository name.

Anyway, this is just for the sake of leaving you some feedback. I'm cool with leaving it the way you propose.

[bhalbright]

Thanks for the feedback, I like your suggestions, what do you think about this idea that emphasizes the issue name and shows the repo name on a separate line...

[bhalbright]

also, FWIW here is a possible view of the search results

[guillep2k]

It looks OK. The fact that the issue titles are all made up might confuse a little, because they look less relevant than the numbers (i.e. [#1] looks more relevant than this is a cool issue!), but in real life the issues will have better titles.

I'd separate the repository name from the number with a space (balbright/Repo2 #2 vs. balbright/Repo2#2) because when they are together the look like HTTP anchored links.

[bhalbright]

@guillep2k thanks, sorry for the delay didn't have much time last week to work on this...wanted to run one more by you guys, hope I'm not beating a dead horse. The layout in the view where you list the dependencies below is based on what github does when you search for issues across all of github. I wanted to do the same in the search dropdown but floating the issue # to the right didn't look right in the small box so I put it to the left of the title there.

[guillep2k]

Looks good to me.

[mappu]

Cross-repository dependencies have appeared in my 1.11.0-rc1 installation.

But there is a problem with mentions - the inline "X added a new dependency" message still links to the current repository, not the target repository

[lunny]

@mappu could you fire another issue to report that? I will close this one since it has been implemented.

[guillep2k]

Cross-repository dependencies have appeared in my 1.11.0-rc1 installation.

But there is a problem with mentions - the inline "X added a new dependency" message still links to the current repository, not the target repository

@mappu that bug has already been reported at #9765 👍

[6543]

does #7901 not close this issue ?!?

[bhalbright]

does #7901 not close this issue ?!?

yeah I would agree the issue could be closed