git version 2.17.2 (Apple Git-113)
[x]
): Not relevant@lafriks shouldn't we close this issue now that the PR is merged?
And I noticed that the 1.8.0 milestone has nothing left once this is closed. So can we close this and create a new release or are we gonna test a little more?
It's "fixed" however, perhaps we leave this open so that a more permanent solution could be found.
Edit: We just released RC2 of Gitea, so if you want to test it so we can release a final 1.8.0 that would be helpful
@rakshith-ravi you really should take a look at my fix. It's really not a permanent solution and should only be considered a stopgap. I wouldn't really want this to stay in the code for too long - not least because I think it makes me look bad!
Haha okay. I'll see if I (or someone from my team) can get that fixed up.
But thanks for the fix anyway. The fact that we have a fix is good news. We'll get to cleaning it up asap.
Btw, @techknowlogick as per your request, I've migrated my company to 1.8.0-rc2 so I'll report any bugs that I find here. Will keep you guys posted.
Can we close this as https://github.com/go-gitea/gitea/issues/6464 is now tracking the hack?
@adelowo yup. Thanks for pointing that out.
Closing per above comment.
Most helpful comment
Haha okay. I'll see if I (or someone from my team) can get that fixed up.
But thanks for the fix anyway. The fact that we have a fix is good news. We'll get to cleaning it up asap.
Btw, @techknowlogick as per your request, I've migrated my company to 1.8.0-rc2 so I'll report any bugs that I find here. Will keep you guys posted.