Gitea: Label emojis aren't rendered in milestone view

Created on 14 Mar 2019  路  4Comments  路  Source: go-gitea/gitea

Emojis in labels aren't rendering when using the milestone view.

Screenshots

Milestone View
Expected behavior

kinbug

All 4 comments

Looks like this page also doesn't have the same UI changes made to the issues page.
Thanks for catching this, I'll try to whip up a PR for it. 馃憤

Side-note, I cannot get to the posted milestone page. It seems that seeing the milestone page that lists all issues/PRs requires write access to either issues or pulls. Shouldn't it be read access to see the page?

https://github.com/go-gitea/gitea/blob/8fffb0616866cfe7a293b457d8703724666374cb/routers/routes/routes.go#L636-L638

@jolheiser I think that maybe another bug but after you change that to reqRepoIssuesOrPullsReader, you also need to change the UI to disable Edit milestone and change status of issues or pulls if user haven't reqRepoIssuesOrPullsWriter.

@lunny Sounds good. I'll open a new issue to address that, since I'd rather get the UI fixes in first for this issue.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

flozz picture flozz  路  3Comments

adpande picture adpande  路  3Comments

lunny picture lunny  路  3Comments

Fastidious picture Fastidious  路  3Comments

jakimfett picture jakimfett  路  3Comments