Gitea: Markdown checkboxes in tables

Created on 28 Jan 2019  路  9Comments  路  Source: go-gitea/gitea

  • Gitea version (or commit ref): 1.7.0
  • Git version:
  • Operating system: Archlinux
  • Database (use [x]):

    • [ ] PostgreSQL

    • [ ] MySQL

    • [ ] MSSQL

    • [x] SQLite

  • Can you reproduce the bug at https://try.gitea.io:

    • [x] Yes (https://try.gitea.io/transferkraM/markdown-checkbox-table)

    • [ ] No

    • [ ] Not relevant

  • Log gist:

Description

Checkboxes inside markdown tables are not rendered as checkboxes. See https://try.gitea.io/transferkraM/markdown-checkbox-table.

kinbug revieweconfirmed

All 9 comments

Another issue is the dots before the checkboxes. Put an inline "list-style-type: none" on these elements.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

Push.

^bump

I think this has been fixed since we use goldmark. Also see the original link https://try.gitea.io/transferkraM/markdown-checkbox-table

I think this has been fixed since we use goldmark. Also see the original link https://try.gitea.io/transferkraM/markdown-checkbox-table

@lunny I don't see this fixed. I expect to see checkboxes inside the table.

A couple things I've noticed:

  1. I can't interact with checkboxes in a PR. (e.g. I can't click on it to mark it done)
  2. Checkboxes are rendered with a bullet (it normally isn't rendered with one, see example below)

    • [ ] task 1

    • [ ] task 2

This bug is present in Gitea 1.11.4, and it's rather annoying. I confirm that the flaws @maria-lau stated regarding interaction and nonstandard (redundant) bullet symbols are present in the most recent release, according to changelogs since 1.11.4.

Note

It's possible that the release candidate tagged v1.12.0-rc1 solves the problem, with respect to #10798 (Completely fix task-list checkbox styling.) Nevertheless the release candidate is not a release, and it's unclear if the bug #10798 solves this problem as well.

I cannot find the spec that describes how checkboxes are supposed to work in tables. GFM doesn't appear to have these:

inside table

| checkboxes | description |
|------------|-------------|
| [ ] | unchecked |
| [x] | checked |

I have fixed the appearance of normal checkboxes in #10798 - I haven't backported them as we're in the midst of prepping for 1.12 - feel free however to make your own PR.

In terms of making these clickable and submittable - this is not supported as yet. Again PRs are welcome but it's not a simple thing to make work.

Was this page helpful?
0 / 5 - 0 ratings