Gitea: Reaction-emojis should not have a human skin colour

Created on 20 Oct 2018  路  9Comments  路  Source: go-gitea/gitea

  • Gitea version (or commit ref): dea3d84
  • Can you reproduce the bug at https://try.gitea.io:

    • [x] Yes

    • [ ] No

    • [ ] Not relevant

Description

The thumbs-up and thumbs-down emojis currently have a human skin colour, whereas the faces are in "smiley-yellow". The thumbs should be in that same yellow.

Screenshots

screenshot_2018-10-20t17 46 33

kinenhancement kinui revieweconfirmed

Most helpful comment

Should gitea not stick to utf8 and let the web browser decide what it looks like? ( Internet Explorer has pigment neutral emoji) ... at least use a custom font for vector instead of rasterizing them.

All 9 comments

We should switch to twemoji to achieve this. Probably also moving the parsing emoji tags and converting to image tags in golang side

Should gitea not stick to utf8 and let the web browser decide what it looks like? ( Internet Explorer has pigment neutral emoji) ... at least use a custom font for vector instead of rasterizing them.

@Dmole if you use UTF-8 and let browsers decide how things look some emoji can get extremely confusing as each browser has a different emoji setup and some companies have imagined some emojis differently than others, I can't think of an example off the top of my head but I know that there are several emoji where on one phone it portrays happiness and on the other it looks angry/sad

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

Are bots deciding what an important issue is and what is not? Did you have a discussion about the ethical implications? Where can I read it?

@tastytea It was discussed in the maintainers chat channel, as well as you can find the PR for it here: https://github.com/go-gitea/gitea/pull/5243

It is being used as a tool to help the maintainers to ping issues that may need feedback. We have been able close several issues that needed to be closed, but were just forgotten. As well, it reminded some maintainers of open PRs that could easily be merged. Some issues that stalebot ping'd should remain open, and we've been able to keep them open, so a maintainer is still making a final decision.

Since I know next to nothing about go or web development, I have resorted to a hotfix for now: Overwriting the 6 reaction-emojis with Twemojis. If you want to do the same you need to download:

And then copy the files to public/vendor/plugins/emojify/images before compiling.

screenshot_2019-10-30T13-30-03

UTF8:
馃憤 馃憥 馃檪 馃檨 馃挀 馃帀

I'd support using Twemoji

Was this page helpful?
0 / 5 - 0 ratings