Gitea: Docker footer show the commit instead of tag version in 1.5.0

[EnricoFerro]

• Gitea version (or commit ref): 1.5
• Git version:
• Operating system: Docker
• Database (use [x]):
  
  
  
  • [ ] PostgreSQL
  
  
  • [ ] MySQL
  
  
  • [ ] MSSQL
  
  
  • [ ] SQLite
  
  
• Can you reproduce the bug at https://try.gitea.io:
  
  
  
  • [ ] Yes (provide example URL)
  
  
  • [ ] No
  
  
  • [ ] Not relevant
  
  
• Log gist:

Description

In Docker in the footer of the page the displayed version is the commit instead of the version of the tag.
I see this description for the version 1.5.0 / 1.5.0-rc2 / 1.5.0-rc1 / 1.5.0-dev.

The version 1.4.3 show the correct version ( 1.4.3 )
...

Screenshots

Version 1.5.0:

Version 1.4.3:

[lafriks]

Are you using tag 1.5 or 1.5.0?

[EnricoFerro]

I use this docker-compose.yml:

version: "2"

networks:
        gitea:
            external: false
services:
    gitea:
       container_name: gitea
       image: gitea/gitea:1.5.0
       environment:
           - USER_UID=112
           - USER_GID=117
       restart: always
       networks:
           - gitea
       volumes:
           - /home/git/gitea:/data
       ports:
           - "127.0.0.1:3000:3000"
           - "127.0.0.1:10022:22"

and launch:

sudo docker-compose up -d --build

[lafriks]

Hmm, strange. Must be something to do with that standard tag drone feature

[namadori]

It seems the fix doesn't work. On 1.6.0 the footer says "0da8bc9".

[jojomi]

Still only the hash in 1.7.0 (3fa49f3). Would be nice to see this fixed, so successful updates can be verified more easily :).

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[TBK]

Still an issue with 1.8.0.

[lunny]

~Did you get gitea binary from the https://dl.gitea.io ? One of my instance display correctly.~

[webjoel]

@lunny Problem is only in Docker..

[TBK]

As @webjoel said it is a problem with the Docker build.

[segevfiner]

I think tags: true doesn't actually exist in Drone, and you need to do git fetch --tags by yourself as a separate step to get the tags. See Drone - --tags

[TBK]

You can use DRONE_TAG to get the git tag in some circumstances - https://docs.drone.io/reference/environ/drone-tag/

[sapk]

The problem is that the variable DRONE_TAG and DRONE_BRANCH that are used in the Makefile are not forwarded to the docker context and so the the build inside docker doesn't take them into account.

[zeripath]

Fixed by #6836 and its backport #6839

[zeripath]

Hmm actually this one might not be fixed - it depends on when we make the tag. If we tag after building then that's the problem... it should be fixed but we should check again next tag.