Gitea: Cannot comment in split diff view

[jonasfranz]

• Gitea version (or commit ref): b1ad573
• Can you reproduce the bug at https://try.gitea.io:
  
  
  
  • [x] Yes: https://try.gitea.io/go-gitea/chardet/pulls/1/files?style=split&whitespace=
  
  

Description

1. It is not possible to add new comments in split diff view because the '+'-button does not show up Resolved by #5038
2. It is not possible to submit a comment at an existing conversation.

[jonasfranz]

Reopen since 2. is not resolved.

[lunny]

@JonasFranzDEV I think this should be an enhancement but not a bug. And moving it to v1.7 is better.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[rfwatson]

Seems to be happening because this event listener is hijacking the click in split view. It isn't bound in unified view.

You can try removing the listener from the button using Chrome devtools in split view, the issue is immediately resolved.

[lunny]

@rfwatson could you send a PR to fix that?

[silverwind]

https://github.com/go-gitea/gitea/pull/7052 was merged, this can be closed, right?