Gitea: Bad URL detection in Description field

Created on 5 Jun 2018  路  8Comments  路  Source: go-gitea/gitea

  • Gitea version (or commit ref): fa3ceb6 (try.gitea.io)
  • Git version: (not relevant)
  • Operating system: (unknown)
  • Database (use [x]):

    • [ ] PostgreSQL

    • [ ] MySQL

    • [ ] MSSQL

    • [ ] SQLite

  • Can you reproduce the bug at https://try.gitea.io:
  • Log gist:

Description

If I include URL inside parentheses in Description of a git repo, gitea web UI will linkify it, but the closing bracket will be detected as art of the URL, resulting in HTTP-404 errors.

Screenshots

http://file.vornet.cz/tmp/rbrack.png

kinbug revieweconfirmed

Most helpful comment

This is fixed as of 71b734b (link in previous comment now works as expected)

All 8 comments

I don't know if this is an issue that needs to be resolved, because there is already a URL field for URLs to go into.

@techknowlogick if this usage is not intended, maybe don't detect URLs in this text at all?

It could still make sense to include another URL in this field.

I like @davidak 's idea.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

This issue has been automatically closed because of inactivity. You can re-open it if needed.

I can still reproduce it on 28fcbf3: https://try.gitea.io/davidak/test4

This is fixed as of 71b734b (link in previous comment now works as expected)

Was this page helpful?
0 / 5 - 0 ratings