Gitea: Proposal: Drop integrated tidb support

Created on 18 May 2018  路  5Comments  路  Source: go-gitea/gitea

TiDB since v2 seems to drop the integrated database model and shift to provide a scalable/distributed/mysql compatible independant database server.
So I propose to drop support for the old version that seems to not be use and we haven't provided test or binary for it. We should still be compatible since TiDB is compatible with mysql.

I might be misleading so this PR is to find out if someone use it or if everyone is ok with this proposal.

kinproposal
Source
picture sapk
👍1

Most helpful comment

What if we announce that we are going to do this in the 1.5.0 release blog post, and then merge it into master right after 1.5.0 is released that way it will be in 1.6.0

picture techknowlogick on 22 May 2018
👍2

All 5 comments

~And it seems that gitea doesn't build with tidb tags :~
I had some changes in /vendor kept from when trying to update to last v1 version that was failing.

sapk picture sapk on 18 May 2018

Since we could use xgo to cross-compile sqlite. I think remove embed tidb support is acceptable.

lunny picture lunny on 19 May 2018

PR ready as this is easy (#3993) but before I think we should wait if anyone complain.

sapk picture sapk on 20 May 2018

What if we announce that we are going to do this in the 1.5.0 release blog post, and then merge it into master right after 1.5.0 is released that way it will be in 1.6.0

techknowlogick picture techknowlogick on 22 May 2018
👍2

I've added the note about this to the upcoming 1.5.0 blog post, and PR has been merged so I will close this ticket.

techknowlogick picture techknowlogick on 4 Jul 2018
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

lunny picture lunny  路  3Comments
cookiengineer picture cookiengineer  路  3Comments
thehowl picture thehowl  路  3Comments
BRMateus2 picture BRMateus2  路  3Comments
internalfx picture internalfx  路  3Comments