Gitea: Pushes via deployment write keys do not trigger reindex

[mqudsi]

• Gitea version (or commit ref): 38a9cda
• Git version: n/a
• Operating system: n/a
• Database (use [x]): n/a
  
  
  
  • [ ] PostgreSQL
  
  
  • [ ] MySQL
  
  
  • [ ] MSSQL
  
  
  • [ ] SQLite
  
  
• Can you reproduce the bug at https://try.gitea.io:
  
  
  
  • [X] Yes: https://try.gitea.io/mqudsi/test-deploy
  
  
  • [ ] No
  
  
  • [ ] Not relevant
  
  
• Log gist:

Description

It seems pushes to repos with rw deployment keys do not trigger a reindex of the repo or the "commit" event.

1. Create repo
2. Add deployment key with write access
3. Push to repo with deployment key
4. webui does not reflect changes, repo continues to show as if new

Reproduced on try.gitea: https://try.gitea.io/mqudsi/test-deploy
That repo appears blank, but it has content.

[bjoe2k4]

This bug just hit me hard and took me hours to realize what the problem was. Any update on this?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[lunny]

@bjoe2k4 need more investigation.

[dakira]

I'm using the latest HEAD and have the exact same problem. Using read/write deploy keys, the cache is not invalidated when pushing, using a user key, it is. Can I help investigating @lunny?

[zeripath]

This is pushing with SSH keys?

I bet the environment variables for the hooks aren't being set properly.

[mqudsi]

Not regular ssh key push, pushing with rw-enabled deployment keys.

[zeripath]

Yep, taking a look at gitea cmd/serv.go the environment settings aren't properly set.

[zeripath]

I've pushed a branch to github but not opened a PR just yet until I've had a chance to test it

[lunny]

@mqudsi maybe you can confirm that #5935 fix this issue.

[dakira]

@lunny I can confirm this fixes the issue.