Gitea: PR acceptance blocked for PR creator
- Gitea version (or commit ref): 1.2.3
Description
Our development team was thinking to use PR system to review our code, is there any feature to block the creator of the PR to accept it?
Screenshots
On that example, the user administrator created de PR and accepted it.
lucasfantacuci
All 9 comments
Right now, I don't think so. Probably only possible when #2794 is done. But correct me if I'm wrong.
mbger
on 19 Feb 2018
I'm pretty sure that you can set a collaborator's permission to 'Read', and that should grant them ability to make PRs & such, but not push directly. Although, of course, a repo admin / someone with write access would be needed to merge the PR.
thehowl
on 20 Feb 2018
resolved by https://github.com/go-gitea/gitea/pull/3689
lunny
on 11 May 2018
@lunny this is not resolved by #3689 - if the PR creator is on the whitelist they can merge. #2794 was abandoned. Is there any other issue in progress that would deliver this?
cailyoung
on 24 Apr 2019
@cailyoung you can set that PR needs at least one approval
lafriks
on 24 Apr 2019
@lafriks 's idea is correct.
lunny
on 24 Apr 2019
@lafriks @lunny
Apologies, we are not running 1.6.0 or newer. I will have a chat with the team here.
cailyoung
on 24 Apr 2019
So #3748 fixes this - i.e. the PR creator cannot be an approver?
cailyoung
on 24 Apr 2019
@cailyoung yes, one could not approve himself PR.
lunny
on 24 Apr 2019
Related issues
jorise7
路
3Comments
BRMateus2
路
3Comments
internalfx
路
3Comments
ghost
路
3Comments
jonasfranz
路
3Comments
Most helpful comment
Right now, I don't think so. Probably only possible when #2794 is done. But correct me if I'm wrong.