Gitea: Submodules dont linked in subdirs

[tantetoni2]

• Gitea version (or commit ref):
• Git version: 5332052
• Operating system: debian 8 with docker
• Database (use [x]):
  
  
  
  • [ ] PostgreSQL
  
  
  • [X] MySQL
  
  
  • [ ] MSSQL
  
  
  • [ ] SQLite
  
  
• Can you reproduce the bug at https://try.gitea.io:
  
  
  
  • [X] Yes (provide example URL)
  
  
  • [ ] No
  
  
  • [ ] Not relevant
  
  
• Log gist:

Description

Submodules only linked in the root of the repo
reproduce on https://try.gitea.io

Submodules
https://try.gitea.io/tantetoni2/submodule
https://try.gitea.io/tantetoni2/private-submodule

In the root submodules are linked
https://try.gitea.io/tantetoni2/repo

but in subdirs they not linked
https://try.gitea.io/tantetoni2/repo/src/branch/master/submodules

...

Screenshots

[tantetoni2]

when is the bugfix coming?

[lafriks]

Nobody is currently working on this so if you can help to fix this that would be great

[lunny]

Can't visit https://try.gitea.io/tantetoni2/submodule and https://try.gitea.io/tantetoni2/private-submodule

[biesalsk]

Please fix this bug...
Links in root of projects are working:

But links in subdirs are dead:

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[paranoico]

I need also this functionality.

Same as previous issue, why is it marked as Stale if nobody in Gitea team is working on it?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[salco]

It's a huge issue in my opinion, I'm sure it could be quickly fix.
I created a repo to validate the issue since other seems to doesn't work.
https://try.gitea.io/salco/SuperProject
Tell me if it's doesn't work.

[salco]

From what I can find the issue is cause by the code inside repo.go , the function RedirectToRepo.
I've also find a commit that try to fix this issue: 237df2f33987073fdaa1d773faa4c9e87221f9ea .
Maybe it could help someone to fix it.

[mrsdizzie]

This looks to be fixed / working as expected based on https://try.gitea.io/salco/SuperProject right? Particularly the fact that https://try.gitea.io/salco/SuperProject/src/branch/master/folder shows the submodule linked as expected.

[techknowlogick]

Closing per above comment. Please re-open if needed

[mp-pinheiro]

Hi there.

I am still unable to link nested submodules. They work as intended if they're on the root directory, however.

I have the exact same setup as the try.gitea project.

.gitmodules file:

[submodule "steamlua"]
path = steamlua
url = /steamlua.git
[submodule "src/Utils"]
path = src/Utils
url = /Utils.git
branch = master

Root submodule works:

Nested one does not:

Not sure if I'm doing anything wrong.

[salco]

If you look on the try gitea the version is 1.9.0... i'm not sure if it solve it the 1.8.0. On my setup it still doesnt work, I will wait the 1.9.0 to be sure this issue is still there.