While we can upload files on issues, we can't on the wiki. Could this be implemented?
Want to back this issue?
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
IIRC this was being worked on for the new web-editor. But I could be mistaken
@bkcsoft got a link? I would assume this needs more than a web-editor.
https://github.com/gogits/gogs/pull/3443/files#diff-da541ef36e39344f2e12bddd91d363e2R507
Why he close that PR?
bountysource.com, but there are some bugs.
What is the status of this?
Nobody are working on this.
Bounty posted. Small, but I hope someone claims their cup of coffee!
I added a beer, hopefully, drank before the coffee :smile:
Linking to Gogs' issue. Hopefully someone on either side can get it done.
https://github.com/gogs/gogs/issues/2263
Added to the bounty.
I'd like to try tackling this issue.
Are the uploads supposed to be treated like issue attachments or uploaded to the wiki repo?
EDIT: more info on the two options at gogs/gogs#2263
I believe both: some of us (me) are looking for wiki uploads, others for
issue attachments
Il giorno dom 20 gen 2019 alle 20:13 Gabriel Silva Simões <
[email protected]> ha scritto:
I'd like to try tackling this issue.
Are the uploads supposed to be treated like issue attachments or uploaded
to the wiki repo?—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/go-gitea/gitea/issues/574#issuecomment-455893551, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAMLMQZZHwEaZJXps-_v0yEe4Q9EeQ_5ks5vFL_RgaJpZM4LZsse
.
I'd like to try tackling this issue.
Are the uploads supposed to be treated like issue attachments or uploaded to the wiki repo?
EDIT: more info on the two options at gogs/gogs#2263
Upload to wiki repository, and link it to wiki page, just like it is possible on Gtihub issues, for example.
@rlogiacco issue attachments has been implemented already.
@lunny he wasn’t referring to issues attachments directly. He was asking how should uploads be implemented on wiki.
@Fastidious maybe someone could give some UI design ideas? Or just like gitea did on issue comment?
I don't see a problem using the same UI as the issues. Maybe add an icon in the toolbar for file uploads.
repo.wiki
and referencing them using /wiki/raw/*
. Once it gets merged, I will work on a UI for that.I need some input: should users be allowed to upload files to folders inside the wiki repo? Or only to the root folder?
@gabrielsimoes for neatness, and organisational purposes, I prefer to upload to directories within the wiki repository. But why not just allow uploads to the wiki repository, without imposing location restrictions?
Uploading to directories by cloning the wiki repo has always been allowed. The only problem was that /wiki/raw/ had a bug restraining it from serving the files.
I'm currently implementing the UI interface for uploading files to the wiki. Should it allow uploads to specific folders inside the wiki repo? If so, implementing it would involve expanding some of the internal repo code to wiki repos.
Should it allow uploads to specific folders inside the wiki repo?
Since this is to upload files, and use them on the web interface, would using a set directory to hold all uploads be a good idea then? Similar to how issues does it (i.e., /attachments/088cd773-c443-4e46-98f3-6f7f32d678b5
).
As wiki is a repo, I think we should do exactly how we do file uploads on the standard repos, in that it adds a binary file to the underlying git repo. I would like to avoid putting them on server, as that would separate the file from the wiki itself (plus migrations/clones wouldn't include the file). I think LFS would be a good place to put the files, however not all servers have LFS enable, and so that is why I ended up thinking directly in the root of the repo as the place to put them. Please let me know if you need clarification on the wall of text I just wrote.
@gabrielsimoes how goes? Let me know if there is something I can do to make this happen!
I have summed up the tasks here https://github.com/go-gitea/gitea/issues/6975#issuecomment-503125546
We passed the three years mark on this one 🤧. As a reminder, there is a $150 bounty on it.
Anyone?
I've doubled the bounty to $300.
If no one would take it, I'll withdraw by the end of the year.
Since I also need this feature so I'm trying to implement this feature. Here are some progress I made and current implementation can be seen at #12279.
Screenshots about file upload
The current state should just works but I still get some issue not have been solved since I'm not so familiar with the gitea codebase. So it's not ready to merge/use right now. Also since I can only try to work on this feature on my free time, so I probably still need some time to get the feature implemented properly...
Most helpful comment
5814 already allows for manually uploading images to
repo.wiki
and referencing them using/wiki/raw/*
. Once it gets merged, I will work on a UI for that.