Gitea: Commits and pull files

[lunny]

Before we can start a review, we can implement comment on one line of PRs at first.
I think this includes two sub issues.

• [ ] ~Commit comment #3748~ see #4898
• [x] Pull files comment #3748

[bkcsoft]

well, If we implement comments on commits we should get this "for free" :slightly_smiling_face:

[metalmatze]

I'm not sure. I don't know the internals, but the comment may go onto a commit page. Then you can discuss this commit.
But this issue targets a bigger picture. A PR might have multiple commits and those can change over time. So I agree that comments on commits might benefit comments on PR with some work already done nevertheless I feel that there's more to it.

[lunny]

Yes, comment on commits.

[bkcsoft]

I can probably make a proof of concept for this sometime during the weekend or next week

[lunny]

@bkcsoft any update?

[strk]

Aren't we going to do this with git-appraise ? See #733

[sokolovstas]

I can look at this, but this will be not so fast

[lunny]

Move this v1.2 since #733 has moved.

[lunny]

I have tried to do something. Comments on PR is not the same as comments on commits. These are two similar PRs. For comments on PR, all the comments should be indexed by the IssueID, treePath, lineNum and actionType(add line or del line). But for comments on commits, all the comments should be indexed by commitSHA, treePath, lineNum and actionType(add line or del line).

[lcges]

I send the draft as seen to comment on the code.
For some time I will show demo work.

[lcges]

Hello.
I send you a preview of the model of action.
This is a static implementation - proof of concept

gitea_comment_code.zip

[daviian]

@qdbdbp Looks great but I think a button to cancel the comment is missing. How does it look in unified mode?

[lcges]

gitea_c_o_c.zip

I send updated versions.
I'm waiting for comments on this.

[lunny]

@qdbdbp I am working on a branch about this, I will send a PR today or last two days. I will copy your code to that PR.

[lunny]

@qdbdbp It seems only the first comment on the code line. how to show the second or third comment on the same line?

[lunny]

@qdbdbp I have sent a PR #2583 but I think maybe I have lost something from your zip. Please review the code and help me with the UI.

[lcges]

no problem. I will do what I need
I'll take your code and I'm already working on the correct code.

[tonivj5]

@qdbdbp, what tool do you use to do those designs? :sweat_smile:

[lcges]

hi. I use it for quick drafts this tool:

https://mockflow.com/

[KeepMasterBranch]

I don't mind to pay to have this feature... how much? who?

[lunny]

@bclermont we already have a wip pull request #2583.

[KeepMasterBranch]

@lunny yeah, but it can't be merged, and haven't been updated in 6 months! I want to help to implement this feature

[lunny]

You could use https://www.bountysource.com/teams/go-gitea

[techknowlogick]

@lunny thanks for posting that link. I added to the bounty.

[cobbzilla]

Thanks for the bounty link. I added $100 if this can be resolved within 6 months. This is the basically the only feature that I still miss after migrating from Github to Gitea. I will be super duper happy when Gitea supports in-line code reviewing for pull requests. Go Gitea team!

[KeepMasterBranch]

I will give equivalent of 100$ in a crypto currency to whoever earn the bounty

[rc1021]

Are there things to follow?

[lunny]

Please follow #3748

[tonivj5]

Is comment in commits implemented? If it isn't implemented I think this should be reopen

[lunny]

@xxxtonixxx right, Only pull request comment was implemented by #3748 . @lafriks @JonasFranzDEV

[lunny]

But we could open another issue to keep this one closed.

[tonivj5]

:+1:, I will do it

[lunny]

@xxxtonixxx Thank you!