git command `update-git-for-windows` does not work when rc releases are installed

Created on 18 Sep 2018  路  4Comments  路  Source: git-for-windows/git

I recently installed rc2 of git for windows 2.19. After the final release of 2.19 I was not prompted with an update message (auto updates are enabled). Manually updating did not work, as git update-git-for-windows did not return anything.

On manual installation of 2.19 the installer asked me if I want to downgrade.

bug

Most helpful comment

@t-b not only there: the downgrade warning you mentioned is due to InnoSetup failing to detect from looking at the version number in the registry that it was an -rc version. I think we need to make our InnoSetup script smarter so that it stores an extra flag "isPrerelease" or some such, together with the version number before that. Maybe in the PreviousData? That information would then need to be picked up by the "is this a downgrade?" check.

All 4 comments

Correct. This is a long-standing bug, and I continue to fail time to work on this.

If you have time to spare, I would really welcome your help.

@dscho Thanks for verifying it. I'll see what I can do. Note to future self: Here is the place to dive into -> https://github.com/git-for-windows/build-extra/blob/54a4e3f9d0b43267fd9156551b70e7df82eb383b/git-extra/git-update-git-for-windows#L11.

@t-b not only there: the downgrade warning you mentioned is due to InnoSetup failing to detect from looking at the version number in the registry that it was an -rc version. I think we need to make our InnoSetup script smarter so that it stores an extra flag "isPrerelease" or some such, together with the version number before that. Maybe in the PreviousData? That information would then need to be picked up by the "is this a downgrade?" check.

I addressed this in the meantime.

Was this page helpful?
0 / 5 - 0 ratings