Git-updater: Idea: Activate Override Dot Org -> add Exceptions

[erikmolenaarnl]

Hi,

I have a duplicate theme name which required me to set GITHUB_UPDATER_OVERRIDE_DOT_ORG to True. Works great!

But, here comes: I have other plugins which I -_do_- want to update from Dot Org _instead_ of Github.

It would be a great idea to set exceptions for plugins/themes when this setting is active.

I hope my idea is of any use. Thanks for this great piece of code and keep rockin' !

[afragen]

Using this setting only effects plugins or themes that have identical slugs on dot org. Can you give me an example of the behavior you are wanting to prevent?

[erikmolenaarnl]

Hi Andy

Thanks for your quick reply!

I use a theme called "Latest" -> https://github.com/ArrayHQ/latest. This is a duplicate theme name already in use on dot org for another theme. This is why I have set the override to true.

But setting the override also suggests updating FontAwesome to the latest beta on Github: https://www.screencast.com/t/6QO0ATWj. Which I do not want to use in a production environment.

Looking forward to your reply. Thanks again!

[afragen]

I’ll see what I can do about adding a filter to override my override.

[erikmolenaarnl]

Awesome. Where can I give a donation for this awesome plugin project?

[afragen]

There’s a donate link on the README, and thanks.

[afragen]

Just making notes to myself.

Refactor GHU_Trait::is_override_dot_org() to accept array of slugs/file to override instead of blanket override of any potential plugin/theme. This could end up as a breaking change but I’ll try to simply deprecate the constant.

~Pass $transient->response[$plugin->file] or $transient->response[$theme->slug] to function.~

[erikmolenaarnl]

The donation page on your website is not found btw.

[afragen]

Oops, gotta fix that. 🤦🏻‍♂️

[afragen]

@erikmolenaarnl donate link fixed. 😄

[afragen]

@erikmolenaarnl take a look at latest develop branch and above commit.
https://github.com/afragen/github-updater/wiki/WordPress.org-Directory

[erikmolenaarnl]

@afragen I got the development branch but the new filter seems to be ignored:

[afragen]

I didn’t do anything with the dashicon, but any updates should come from the correct place. Looks like I have another part to fix.

[afragen]

@erikmolenaarnl the above commit should fix this dashicon issue.

[erikmolenaarnl]

It works great! Thanks for the quick fix :-)

[afragen]

@erikmolenaarnl what do you think of
https://github.com/afragen/github-updater/commit/1d1821812f8a2dd49027241e9aa0017cb4c7de15?

[erikmolenaarnl]

Great work Andy! It is much clearer now in the plugin settings when an override is in place. Kudos!

[erikmolenaarnl]

Hi @afragen I was just wondering when 1d18218 will be added to the stable/master version?

Sorry if this is a newby question, I am new to Github. Thanks :-)

[afragen]

I will probably add release the next version this week.