Git-subrepo: `status --ALL` doesn't find subrepos on macOS

[peterlobster]

For some reason, when I was trying to update my subrepos today, git subrepo status --ALL doesn't work. I simply get back a No subrepos.

When I got to manually get the status of each one, I'm able to do so; so I'm fairly certain it's a problem with the command finding the repos.

Has this happened to anyone else? If so, how did you fix it? Thanks

[admorgan]

What version are you using?

[admorgan]

While is is obviously wrong that git subrepo status --ALL fails, it is also redundant. The default behavior is to show the status of all subrepos

[peterlobster]

@admorgan Thanks for responding.

What version are you using?

0.4.1 from Homebrew

While is is obviously wrong that git subrepo status --ALL fails, it is also redundant. The default behavior is to show the status of all subrepos

Noted. That also comes back with No subrepos., which you could have probably guessed.

[admorgan]

It is working for me on 0.4.1 and 0.4.2 on both Linux and Windows. I don't have a Mac to play with.

Am I hearing you say is that git subrepo status in your project returns "No subrepos" but if you do git subrepo status path/to/subrepo returns the status of the directory?

[peterlobster]

@admorgan That's exactly what's happening.

If I do, git subrepo status <subdirectory> they work individually. Pretty much anything I do from root project folder with --ALL or --all don't work. I also tried git subrepo pull --all which didn't do anything.

FWIW I'm using High Sierra

[admorgan]

Would it be possible for you to send me a copy of your repo so I can see if I can reproduce it? Or can you make another that behaves similararly?

[peterlobster]

@admorgan Well, I've been trying to make my own 'Codex' of notes, similar to the way @ran-dall does here: https://github.com/ran-dall/codex . He updated his repo this morning though, so I don't know if it might be working for him. I tried setting up the exact same thing and I got this issue. I also then tried pulling his repo and it still has the same issue.

FWIW Homebrew updated git to 2.26.1 yesterday. I dunno it may be related. Everything was working fine about 4 or 5 days ago. So I'm trying to think of what it could be on my side.

[admorgan]

I pulled his and got the same result. The issue seems to be related to the non-ascii characters in the directory names. I have a feeling some quoting is missing from somewhere. Good news is I can reproduce it on my local system

[peterlobster]

@admorgan Well, it least it wasn't just me. Thank you for looking into it.

[peterlobster]

@admorgan Out of curiosity, where could I get 0.4.2? Or is that not an official release yet? Homebrew only has 0.4.1, but I assume it's because the releases of the repo on have 0.4.1.

[admorgan]

It is basically the current development branch. I hoped to have it released a couple of months ago, but you know how life is.

[peterlobster]

It is basically the current development branch. I hoped to have it released a couple of months ago, but you know how life is.

@admorgan All too well.

[ogenodisho]

I had to do this to get around this issue on mac (I've got 11 subrepos which are also all yarn workspaces)

#!/usr/bin/env bash

workspace_name_prefix="npm_package_workspaces_packages_";

echo "Fetching all of the subrepos...";
for i in {0..10}
do
   current_workspace_name="$workspace_name_prefix$i"
   git subrepo fetch ${!current_workspace_name}
done

echo "Pulling all of the subrepos..."
for i in {0..10}
do
   current_workspace_name="$workspace_name_prefix$i"
   git subrepo pull ${!current_workspace_name}
done

echo "Done!"

and then in my package.json I've got this script:

"update-subrepos": "bash update-subrepos.sh"

[hakanderyal]

I pulled his and got the same result. The issue seems to be related to the non-ascii characters in the directory names. I have a feeling some quoting is missing from somewhere. Good news is I can reproduce it on my local system

Similar problem is happening to me on linux. I have 2 subrepos name runic and runic-aura, and runic-aura is invisible when using --all.

I think problem is with this line https://github.com/ingydotnet/git-subrepo/blob/4230226665c9a2c8647fd0374747df2c32ed45d5/lib/git-subrepo#L1536 but my bash knowledge is limited to fix it.