What are the steps to reproduce this issue?
- Visit https://git-secret.io
What happens?
Browser displays an invalid certificate error.
What were you expecting to happen?
The git-secret homepage to load via SSL.
Obviously given it's a static website this isn't the end of the Earth. Basically I just accidentally ran into this as I incorrectly shared a https link.
Any logs, error output, etc?
N/A
Any other comments?
TLDR; The DNS A record should point to:
- 185.199.108.153
- 185.199.109.153
- 185.199.110.153
- 185.199.111.153
The SSL certificate is currently configured for *.github.io, however it looks like Github have supported custom domains in partnership with Let's Encrypt since earlier this year:
https://blog.github.com/2018-05-01-github-pages-custom-domains-https/
Should be reasonably easy to fix, unfortunately it's not the kind of thing I can submit a PR for 😄
What versions of software are you using?
Operating system: (uname -a) …
N/A
Benjamin-Dobell
All 8 comments
@Benjamin-Dobell thanks! I will have a look at it on weekend.
sobolevn
on 28 Nov 2018
@sobolevn anything I can do to help with this?
Seems especially egregious for this project's web site [in particular] to not use https
joshrabinowitz
on 4 Dec 2018
I will have to figure out how this github/pages/letencrypt things work.
Pretty sure to accomplish this task soon.
👍
sobolevn
on 4 Dec 2018
From what I can tell you need to update your DNS records to use the new methods. As noted in the issue notes about using alternate DNS records... you actually have two ways to do this.
- Using ALIAS records (git-secret.io would resolve to sobolevn.github.io using an ALIAS type record) If your DNS host does not support ALIAS then use A record method. Technically this would work with CNAME records, but you'll get into nuances over CNAME vs ALIAS with an apex level record.
- Using A records (git-secret.io would resolve to the list above or follow here: https://help.github.com/articles/setting-up-an-apex-domain/#configuring-a-records-with-your-dns-provider )
After one of those methods is employed, give it 24 hours or so (your ttl is 6 hours it appears) at which point your option should change and let you tick it.
If it continues to be a hassle, you might check out Cloudflare.com as they let you force HTTPS as well, and can front your GH-PAGES.
jmhardison
on 10 Dec 2018
Any movement on this? Any way I can help @sobolevn ?
joshrabinowitz
on 1 Jan 2019
Configured!
» dig git-secret.io +noall +answer
; <<>> DiG 9.10.6 <<>> git-secret.io +noall +answer
;; global options: +cmd
git-secret.io. 10256 IN A 185.199.109.153
git-secret.io. 10256 IN A 185.199.110.153
git-secret.io. 10256 IN A 185.199.111.153
git-secret.io. 10256 IN A 185.199.108.153
And it looks like the process is now finished. But, it is not working at the moment. Github says that it might take an hour to be ready.
sobolevn
on 1 Jan 2019
Confirming it looks good for me. Correctly being forced over to https when trying http, and seeing a lets-encrypt cert issued.
👍
jmhardison
on 1 Jan 2019
Yes, it works! Thanks everyone!
sobolevn
on 1 Jan 2019
Related issues
barak
·
6Comments
sobolevn
·
5Comments
joshrabinowitz
·
4Comments
notjames
·
6Comments
simbo1905
·
3Comments
Most helpful comment
From what I can tell you need to update your DNS records to use the new methods. As noted in the issue notes about using alternate DNS records... you actually have two ways to do this.
After one of those methods is employed, give it 24 hours or so (your ttl is 6 hours it appears) at which point your option should change and let you tick it.
If it continues to be a hassle, you might check out Cloudflare.com as they let you force HTTPS as well, and can front your GH-PAGES.