Git-point: Support iPhone X

[TejasQ]

What Currently Happens?

The app does not use the iPhone X's entire screen

What Would You Like to Happen?

I'd like the app to look beautiful on the iPhone X.

[TejasQ]

Just saw #707

[machour]

😄
Can you confirm that version 1.5.0 is looking good on your iPhone X? The support was developed using a simulator only, we may have missed a few things. Thank you!

[TejasQ]

Actually, it _visually_ doesn't work at all on the iPhone X.

[TejasQ]

I can also confirm that this _is, in fact_ version 1.5.0.

[machour]

@TejasQ thank you so much for verifying! Weird, this should look like this:

@housseindjirdeh was 1.5 published with the iPhoneX PR? Any chance we missed a needed additional step when releasing? 🤔

I see that in XCode, we still target iOS 8:

Extract from https://developer.apple.com/ios/update-apps-for-iphone-x/

Enable full screen native resolution. Your app will run in Full Screen Display Mode on iPhone X if your project’s base SDK is set to iOS 11 and you have a Launch Storyboard or iPhone X launch image.

[housseindjirdeh]

Hmmmm I think you're right @machour - that must be it. I really thought I updated that to 11 before deploying 🤔

Will update in the next few days and redeploy 1.5.1 with that set to the correct target

Apologies @TejasQ - we'll have this resolved as soon as possible

[coderste]

The iPhone X still doesn’t have full screen support - any chance we can get 1.5.1 published to fix this bug?

[RolfKoenders]

@coderste Im using it on my iPhone X and its using the fullscreen. The version currently in the App Store is version: 1.6.0.
// edit: The only issue i notice is that the tabbar is broken once flipped to landscape.

[TejasQ]

Yup. Fixed.