Git-point: LOGIN.FAILURE not defined

Created on 21 Dec 2017  路  6Comments  路  Source: gitpoint/git-point

| Question | Response |
| ---------------- | ----------- |
| Version? | v1.4.2 |
| Devices tested? | Xiaomi mi 4 - Android 5.2 |


What Currently Happens?

Inside file auth.reducer.js in auth folder you are using LOGIN.FAILURE and LOGOUT.FAILURE. However, if you look at in the types you will find that you have defined LOGIN.ERROR/ LOGOUT.ERROR not LOGIN.FAILURE. This is a minor bug, you can just change the names. Look at the utils/action.helper.js to check the declaration.

I am not getting any error therefore I cannot write steps to reproduce it. This is just a bug which I came across while going through your project. Thanks :D



good for beginners

All 6 comments

@pallavbakshi Nice catch! It's a good chance for creating your first PR if you like.

@chinesedfan Sure! Will do so :D

Seems like this was addressed in #685 馃帀

Great work! Sorry I wasn't able to get it done in time. Something personal came up which needed my attention. By the way, I found three more :bug: . This time I will find a fix first and then report the bug. Awesome work guys :D

No worries, there are always plenty things to do around here :) Feel free to join us on gitter at anytime!

@pallavbakshi No problem. You can also report the bug without pull request. Unless you want to hide and fix by yourself. 馃槅

Was this page helpful?
0 / 5 - 0 ratings

Related issues

arthurdenner picture arthurdenner  路  3Comments

JayBizzle picture JayBizzle  路  4Comments

TautFlorian picture TautFlorian  路  5Comments

Antoine38660 picture Antoine38660  路  3Comments

cheshire137 picture cheshire137  路  3Comments