Git-point: Add more tests!

[andrewda]

We can use this issue to divide up some work. I'll add a checklist below with what needs to be done and who it's assigned to. Please comment (or edit yourself in) if you'd like to take on a test!

For newcomers:

1. Choose the component you want to test
2. Comment here which component you'd like to work on
3. We'll update this list with your name

Components

• [x] Badge (@andrewda – #407 )
• [x] Button (@andrewda – #407)
• [x] CodeLine (@andrewda – #407)
• [x] CommentInput (@dyesseyumba - #582)
• [ ] CommentListItem (@jouderianjr - PR pending)
• [ ] DiffBlocks (unclaimed)
• [x] EntityInfo (@andrewda – #407)
• [x] GithubHtmlView (@whitedogg13 - #819)
• [ ] GithubStyle (unclaimed)
• [x] ImageZoom (@jouderianjr - #548)
• [ ] InlineLabel (@jglover - PR pending)
• [ ] IssueDescription (@mmendesas - PR pending)
• [ ] IssueEventListItem (unclaimed)
• [x] IssueListItem (unclaimed)
• [x] LabelButton (@andrewda – #407)
• [x] LabelListItem (@MarioArnt - #818)
• [ ] MarkdownWebView (unclaimed)
• [ ] Members (unclaimed)
• [ ] MentionArea (unclaimed)
• [x] NotificationIcon (@ZahraTee - #677)
• [x] NotificationListItem (@alejandronanez - #589)
• [ ] ParallaxScroll (unclaimed)
• [ ] RepositoryListItem (unclaimed)
• [x] RepositoryProfile (@alejandronanez - #531)
• [x] RepositorySectionTitle (@ZahraTee - #677)
• [ ] SearchBar – Android (@dyesseyumba - PR pending)
• [ ] SearchBar – iOS (@dyesseyumba - PR pending)
• [ ] SectionList (@jamesg1 - PR pending)
• [x] StateBadge (@andrewda – #407)
• [x] ToggleView (@machour – #407)
• [x] UserListItem (unclaimed)
• [x] UserProfile (@alejandronanez - #547)
• [ ] ViewContainer (@lucaslago - #841)

Sections

Actions

• [ ] Issue (unclaimed)
• [ ] Notifications (unclaimed)
• [ ] Organization (unclaimed)
• [ ] Repository (unclaimed)
• [ ] Search (unclaimed)
• [ ] User (unclaimed)

Reducers

• [x] Auth (@jglover - #579)
• [x] Issue (@TFarla - #830)
• [x] Notifications (@jglover - #567)
• [x] Organization (@TFarla - #831)
• [x] Repository (@TFarla - #832)
• [x] Search (@jglover - #574)
• [x] User (@TFarla - #833)

Screens

• [ ] Auth (unclaimed)
• [ ] Issue (unclaimed)
• [ ] Notifications (unclaimed)
• [ ] Organization (unclaimed)
• [ ] Repository (unclaimed)
• [ ] Search (unclaimed)
• [ ] User (unclaimed)

Utilities

• [x] Action Helper (@alejandronanez - #555)
• [x] Color Helpers (@ibotdotout - #565)
• [ ] Event Helpers (@andrewda - PR pending)
• [ ] Loading Animation (unclaimed)
• [ ] Localization Helper (unclaimed)
• [x] Migration Helper (@mbelsky - #814)
• [ ] Method Helpers (@MarioArnt)
• [x] Text Helper (@ibotdotout - #568)

Miscellaneous

• [x] API (@jjlljj - #746)
• [x] Locales – see #478 (@chinesedfan - #594)

[jouderianjr]

I'll start slow :) Could you give me ImageZoom and CommentListItem? 💃

[alejandronanez]

~I can grab userProfile and RepositoryProfile.~ Already edited the list!

[machour]

I'd like to implement tests for <GithubHtmlView /> but I'm not sure how to implement them with Enzyme. (I'm fairly new to testing :relaxed:)

This component does two things:

1. Transform a given HTML to a new HTML with some modifications
2. Hands out this new HTML to <HTMLView />

Should I stick to only testing the first part, or should the output result of be tested too?
What would be the best way to test the HTML transformation (1.) without relying on jest snapshots?

[andrewda]

Yea, I'd stick to the first part (we should really only be testing one component per test, and involving <HTMLView /> in any way gets a little iffy). For testing the transformations, how about adding a couple data files to a __tests__/data/html directory along with their corresponding expected result. Feed the input HTML from the data files into <GithubHtmlView /> and compare the output with the expected output from the result file.

[jglover]

I'll take InlineLabel and perhaps a reducer

[andrewda]

Thank so much @jglover!!

[ibotdotout]

I'll take Color Helpers, Text Helper in Utilities

[serhii-baraniuk]

Oppps. I haven't noticed that @ibotdotout decided to do tests for color helpers :(

[jglover]

Tackled notifications reducer tests, see #567

[dyesseyumba]

I want to take "SearchBar – Android" and "SearchBar – iOS"

[andrewda]

@dyesseyumba <3

[jamesg1]

I'll take "SectionList" please. Thanks

[ZahraTee]

If this effort is still ongoing, I can take NotificationIcon and RepositorySectionTitle. :)

[machour]

@ZahraTee oh yes it is! We're at ~40% coverage for now, which is better than nothing, but still low.
Assigned both tests to you, let us know if you need any help at all with your PR!
Thank you 🙏

[mbelsky]

I'd like to write tests for utils/migration-helper.js

[MarioArnt]

I'd like to test the following:

• Method Helpers
• LabelListItem

[lex111]

I'd like to test the following:

@MarioArnt fine, but please a separate PR for each component.

[TFarla]

I would like to pick up tests for the reducers:

• ~Issue~ (pull request)
• ~Organization~ (pull request)
• ~Repository~ (pull request)
• ~User~ (pull request)

[lucaslago]

Hi, I'd like to test the ViewContainer component

[lex111]

@lucaslago fine, good luck!

[housseindjirdeh]

Thank you @lucaslago, appreciate it 🙏🏾

[mmendesas]

Hi, I'd like to test the IssueDescription component

[alejandronanez]

@mmendesas go for it

[nersoh]

Can I take IssueListItem?