Git-point: Show issue events

[TautFlorian]

Hey guys,

What about adding the issue events and pr events to gitpoint?

So anybody knows who added the labels und requested the views and stuff.

Found this area in the api docs, that should be what is needed: https://developer.github.com/v3/issues/events/

[dzulfahmi]

Hallo, I'm interested with this issue. Can I help you?

[housseindjirdeh]

Thank you @FlorianTaut this is something we should definitely include :) Yes we would love your help @dzulfahmi!

[housseindjirdeh]

Please don't hesitate to leave screenshots/ideas/suggestions on how you think it should look - definitely open to suggestions if any kind

[housseindjirdeh]

Still think this issue is up for grabs :) Definitely something that would be awesome to have!

[brandly]

@housseindjirdeh i started working on this. does the general approach look okay?

at this point, the plumbing is in place, but the styles need some work:

also, i have some uncommitted changes to ios/GitPoint.xcodeproj/project.pbxproj and ios/GitPoint/Info.plist involving a Feather.ttf file. i haven't run anything besides the regular yarn commands, so i'm not sure where those changes came from.

all feedback is appreciated. i'm familiar with react/redux but fairly new to react-native, so i bet i'll have some styling/packaging hurdles to get over. thanks in advance 🌟

[andrewda]

Looks great @brandly! One thing I'd suggest is moving the text further to the left, removing the space for the image (unless we want an image there?). Also, the "2mo" is cut off on the third event, but it shouldn't be too hard to wrap those lines!

[brandly]

what do you think of this design approach? i've still got implementation details to sort out, but i like this direction.

[lex111]

@brandly Good! Why in the screenshot there is no title change event? And @andrewda add three labels at a time, so this should be one event with three labels?

[brandly]

Why in the screenshot there is no title change event?

it hasn't been built yet! i just wanted to confirm the approach before i did too much more.

And @andrewda add three labels at a time, so this should be one event with three labels?

the api treats them as separate events. we could combine them if we'd like.

[lex111]

@brandly sorry, I just wanted to see what a multi-line event line would look like.

It is better to combine, of course, if several labels have been added at one time.

[brandly]

no worries! current styles aren't handling multi-line events well at all. i'll fix that before i send screenshots. i'll figure out how to combine the label events too.

now that i've got some UI pieces in place, it shouldn't take long to build out the other event components. i'm taking a break tho ✌️

[lex111]

@brandly ok, then this issue will be assigned to you.