Git-point: Crash when commenting on issue

[andonyns]

I was commenting on an issue and the app crashed. I then came back and posted the message again and it worked. I don't know if you have something like crashlytics with the app but I couldn't reproduce it to make it clearer

[andrewda]

Yep, I noticed this too. Not sure what the problem is.

[housseindjirdeh]

Ah thanks folks. Would you happen to know which issue this error happened - I hope I can reproduce this locally to figure out what's going on (I have a strong feeling this is culprit).

[pfinkbeiner]

Same here… At least on my iPhone I can reproduce it.
At the beginning everything works like expected. But when I try to open an issue in a repository which is private, I don't get any feedback after submitting and the app freezes.

The strange part is: after this freeze happend I'm not able to open any other issues on public projects. The app quits immediately.

[housseindjirdeh]

Hmmm @pfinkbeiner that is kinda concerning. we'll dive in and I'll try to reproduce this issue locally with a private repo as well. Will keep you folks posted

[chinesedfan]

@pfinkbeiner @housseindjirdeh I guess it is related to #320. The key point is visiting some empty issues.

@AndonyNS @andrewda You mentioned "commenting", which means the issue screen is opened correctly. Then it will be another problem.

[TautFlorian]

@chinesedfan i think its not fixed with #320 unfortunately, i have crashes when posting a comment some times. I believe it only crashes when tagging someone with @.

But im not sure this causes the problem to a 100%

[SirWindfield]

It is still happening on my android phone. It's quite annoying since I use GitHub apps mainly to communicate for issues/pr.

It happened on every comment I posted within this issue, even the ones without mentions. I send the crash log using the Send feedvack feature from android itself. The email has trash within its name, in case you already received it.

It even happened on the last comment from me. And I made sure to not use @mentions.

Edit:: I don't want to be mean but commenting on issues or pr is imo a basic feature that should work in every git client 😅 I'm rocking version 1.3.0, app tells me it's the newest.

[andrewda]

Yes, this still needs to be fixed and should be done as soon as possible.

[SirWindfield]

Anything I can do to help you identify the probem? Maybe run a debug version of the app somehow?

[machour]

@SirWindfield can you tell us the exact comment that you were posting? There might be something in the text that is not well handled.

You can run a debug version by cloning this repo & compiling the app on your phone. That would be really helpful!
The setup section of our contributing guide should get you started, and we will be available on gitter if you need some support with that.

[SirWindfield]

It crashed on every single comment that I posted over there. Going to clone and install it on my phone, give me a sec.

Edit: I am currently on a metered connection until my ISP fixes the cables outside of the house. Will post an update once that is done :)

[machour]

I'm able to reproduce this on master, with the following flow:

1. Start the app
2. Go to notifications and pick an issue
3. Comment it

Crash message:

[SirWindfield]

After some fiddeling, I am getting exactly the same error message :smile:

[chinesedfan]

@machour @SirWindfield I hope it has been fixed in #658. Check it!

[machour]

@chinesedfan working for me on Android and iOS, a big thank you mate!
@SirWindfield if you want to test this PR, do the following:

cd git-point
wget https://patch-diff.githubusercontent.com/raw/gitpoint/git-point/pull/658.diff
patch -p1 < 658.diff

then compile the app like you did to reproduce the error.

[SirWindfield]

Nice, patch is working :smile: