Git-point: Display repository language

Created on 19 Jul 2017  路  16Comments  路  Source: gitpoint/git-point

The repository's primary programming language string can be found at repository.language.

assigned enhancement

Most helpful comment

Actually - I think a better place to put it would be right up top now that I think about it:

image

Once the user scrolls down the sticky header would hide it anyway - but I think it can live nicely up there :D

What do you folks think?

All 16 comments

Do you have an idea of where you'd like to show it on a repository page?
I don't think create a new Section is a good idea, it takes up too much space

No idea. I really like how it's displayed on the pinned repositories section on GitHub, so we could use that for reference!

Hum, something like that ?

Yea that looks great @Antoine38660!

Ok, I'll try to do this one 馃槈

Last one, do you have any idea about how to generate/choose the circle color ? (To be consistent with Github web)

Not sure if they're necessary (though I kinda like them :wink:), but we can use https://github.com/ozh/github-colors/blob/master/colors.json

Oh nice! There is also this one https://github.com/github/linguist/blob/master/lib/linguist/languages.yml (Officially used by Github)

I already take care of language colors in the codebase, theres a langaugeColors object in the colors config file. That's how I display repository language colors in the repository list screen :)

Definitely understand not needing another section list for this - but not sure if I like it hooked to the bottom of the top section. Play around with it and we can easily move its location at a later point, but I'm thinking along one of the corners maybe?

You can compare location :

| Left aligned | Centered |
|:-:|:-:|
| screenshot_1500475002 | screenshot_1500475026 |

Of course, we should add some margin but I currently prefer the centered one.

Testing on Android today, the rendering is nice :smiley:

They both look good to me, but in the screenshots above I slightly prefer the centered.

What about putting it after "Forks" in the right-center?

This is great @Antoine38660, I'm personally a fan with having it either left or right aligned instead of centered. However my bigger concern than location is adding a little padding from the edges.

I'll leave you with the decision to either have it in the center or not :) but I think it might look a little nicer if it's not _touching_ the edges/corner and there's a little margin/padding regardless of location.

Actually - I think a better place to put it would be right up top now that I think about it:

image

Once the user scrolls down the sticky header would hide it anyway - but I think it can live nicely up there :D

What do you folks think?

That sounds (and looks) good!

Yes, the top centered option looks good :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

gulien picture gulien  路  5Comments

nikolaevigor picture nikolaevigor  路  3Comments

kamasheto picture kamasheto  路  3Comments

JayBizzle picture JayBizzle  路  4Comments

housseindjirdeh picture housseindjirdeh  路  5Comments