Git-point: Reactions

[housseindjirdeh]

So I spent a bit of time some while ago working on adding reactions. This is all in the with-reactions branch of the repo. Keep in mind this is a much older branch and there have been a lot of changes since than on master, but I feel we can port our logic from there when we're ready.

This is what I had working:

You'll notice Slack inspiration there :P

An important thing to point out is that the Reactions APIs are still in development preview. Definitely worth discussing if we wouldn't mind including it now and changing it in the future _or_ if that's not the safest option just yet.

Looking forward to having this rolled out eventually. Discussions/contributions are always welcome :)

[SammyIsra]

Since we are moving to GraphQL, this is worth taking a look at https://developer.github.com/v4/reference/mutation/addreaction/

Also, getting the reactions seems also somewhat intuitive with GraphQL. Altho the end result seems a bit messy, but I am sure we can work with it!

[RolfKoenders]

That looks really nice @housseindjirdeh!

[housseindjirdeh]

Thanks @RolfKoenders :)

Nice thank you @SammyIsra - with REST things were _quite_ messy and I really think this can be something we can integrate after we have GraphQL integrated.

[housseindjirdeh]

That being said - looking at the documentation for API v4 I don't see a mention of reactions being in preview mode like it is in the REST docs. @SammyIsra do you know if we need a preview URL or something of that sort to access reactions with GraphQL?

[andrewda]

@housseindjirdeh No developer preview header is needed for reactions in API v4, it's all implemented and standard 👍

[housseindjirdeh]

OMG OMG OMG

Time to make the move to GraphQL :)

[housseindjirdeh]

If it's okay with everyone - I'll like to take this on and tackle it over Christmas break and start my first stab at using GraphQL :)

[andrewda]

👏 1.5 is going to be a good one!