Giraffe: Tests may no longer be valid in next release of AspNetCore3

Created on 27 Jul 2019  路  4Comments  路  Source: giraffe-fsharp/Giraffe

Pubternal APIs have been removed in the latest AspNetCore3.0. I noticed that the Microsoft.AspNetCore.Internal namespace is opened in some test files. You should either respond to Fowler or plan to change how tests are implemented.

  • [ ] [HttpContextExtensionsTests.fs](https://github.com/giraffe-fsharp/Giraffe/blob/008674757698a1f931f679b2b9f3bcb554cac3f2/tests/Giraffe.Tests/HttpContextExtensionsTests.fs#L7)
  • [ ] [ModelBindingTests.fs](https://github.com/giraffe-fsharp/Giraffe/blob/7981279dfef1432b271975449c8fcb5935cf977c/tests/Giraffe.Tests/ModelBindingTests.fs#L10)

https://github.com/aspnet/Announcements/issues/377

aspnetcore3.0 ready for release
Source
picture panesofglass
👍2

Most helpful comment

Looks like we can just remove the namespace once we upgrade.
https://github.com/aspnet/AspNetCore/pull/11429/files#diff-4ffa5b3e2cc2559caaf05c447c34f31e

picture slang25 on 27 Jul 2019
👍2

All 4 comments

Thanks for the heads up 馃槂 I'll do some investigating. It looks like it's just QueryCollection we are using at the moment.

slang25 picture slang25 on 27 Jul 2019

Looks like we can just remove the namespace once we upgrade.
https://github.com/aspnet/AspNetCore/pull/11429/files#diff-4ffa5b3e2cc2559caaf05c447c34f31e

slang25 picture slang25 on 27 Jul 2019
👍2

Out in 4.0.0

dustinmoris picture dustinmoris on 29 Sep 2019
👍1

Thanks, @dustinmoris!

panesofglass picture panesofglass on 29 Sep 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Disco-Dave picture Disco-Dave  路  4Comments
nicolocodev picture nicolocodev  路  4Comments
alfonsogarciacaro picture alfonsogarciacaro  路  4Comments
padzikm picture padzikm  路  6Comments
hravnx picture hravnx  路  5Comments