we don't need them. Newcomers will appreciate the usage of ( ... )
better remove them now then later when things will break
(we can still add them if REALLY needed)
I agree and we can remove => and <| from usage and in docs, >=> compose operator is still needed if we want to compose HttpHandlers together so will still need that one but good if there is only one?
ok keep the fish, but try to do all docs without it. Whenever you need it, think about a named version of the same operation.
You will be amazed ;-)
@forki From the fsharp chat I can understand why you would like to remove the <| operator from the docs, but I thought the >=> made things a lot easier. Counting myself still as an F# beginner I remember very well when I looked at Suave for the first time and saw the fish operator. Even though I didn't know what it exactly meant, by the look of the code and how apps were composed through >=> I could very easily read and understand what was happening, so I thought it was really good to have.
It's also worth noting that we need to find the right balance between making Giraffe easy for F# beginners, but also make it intuitive for F# power users, since being a beginner is only temporarily and things like the fish operator can very quickly be learnt by reading some Scott Wlaschin articles.
cool, we can remove => & <| from docs, leave fish
on side note, there is function compose that will do same as operator but not as clean writing code and will become nightmare when nesting long complex paths
let app = compose (setStatusCode 404) (text "not found")
Leave fish. But regarding that very last sample. That's Successful.Ok -
without the fish. Reads million times better
Am 30.11.2017 18:28 schrieb "Gerard" notifications@github.com:
cool, we can remove => & <| from docs, leave fish
on side note, there is function compose that will do same as operator but
not as clean writing code and will become nightmare when nesting long
complex pathslet app = compose (setStatusCode 404) (text "not found")
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dustinmoris/Giraffe/issues/159#issuecomment-348260500,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNEIvToGm6LOofebDyN91niTIZd4fks5s7uWfgaJpZM4Qw3vu
.
Ah sorry it's NOT_FOUND.
calling it a day...
Am 30.11.2017 18:38 schrieb "Steffen Forkmann" sforkmann@gmail.com:
Leave fish. But regarding that very last sample. That's Successful.Ok -
without the fish. Reads million times better
Am 30.11.2017 18:28 schrieb "Gerard" notifications@github.com:
cool, we can remove => & <| from docs, leave fish
on side note, there is function compose that will do same as operator but
not as clean writing code and will become nightmare when nesting long
complex pathslet app = compose (setStatusCode 404) (text "not found")
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dustinmoris/Giraffe/issues/159#issuecomment-348260500,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNEIvToGm6LOofebDyN91niTIZd4fks5s7uWfgaJpZM4Qw3vu
.
Removed it from the docs as requested. Thanks for helping to make the docs better!
Most helpful comment
@forki From the fsharp chat I can understand why you would like to remove the
<|operator from the docs, but I thought the>=>made things a lot easier. Counting myself still as an F# beginner I remember very well when I looked at Suave for the first time and saw the fish operator. Even though I didn't know what it exactly meant, by the look of the code and how apps were composed through>=>I could very easily read and understand what was happening, so I thought it was really good to have.It's also worth noting that we need to find the right balance between making Giraffe easy for F# beginners, but also make it intuitive for F# power users, since being a beginner is only temporarily and things like the fish operator can very quickly be learnt by reading some Scott Wlaschin articles.