Gin: error description of release v1.4.0

Created on 20 May 2019  路  2Comments  路  Source: gin-gonic/gin

Guys, you wrote in description to release v1.4.0 that included PR NEW context: inherits context cancellation and deadline from http.Request context for Go>=1.7 #1690, but you reverted this code. Why?

picture scarbo87

Most helpful comment

@scarbo87 I updated the release documentation in v1.4.0.

picture appleboy on 21 May 2019
👍3

All 2 comments

@scarbo87 sorry about gin v1.4.0 release description, that pull request reverted and please see https://github.com/gin-gonic/gin/pull/1736, thanks!
maybe we should release gin v1.4.1 to fix some issue. cc @appleboy

thinkerou picture thinkerou on 21 May 2019

@scarbo87 I updated the release documentation in v1.4.0.

appleboy picture appleboy on 21 May 2019
👍3
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ccaza picture ccaza  路  3Comments
Bloomca picture Bloomca  路  3Comments
gplume picture gplume  路  3Comments
cxk280 picture cxk280  路  3Comments
nxvl picture nxvl  路  3Comments