I'm using Glide as a dependency manager and I'm using a new feature (ShouldBindUri which I guess it has 30 days merged in Master), can you guys create a new version so we can use those new features?
mdsantosdev
All 30 comments
Can't wait to have validator v9 in the new release :)
Lord-Y
on 6 Jan 2019
version 1.4 will be released on February 2019.
thinkerou
on 11 Jan 2019
@thinkerou appreciate the work you're doing. I think this issue should perhaps stay open until you cut that release. I came here for same reason and had to go digging to find it.
mikestead
on 4 Mar 2019
hello, any update?
dangkaka
on 13 Mar 2019
The milestone is due in a day or so https://github.com/gin-gonic/gin/milestone/9 fingers crossed!
mikestead
on 14 Mar 2019
@mikestead thanks! Due date is only an estimate. we still need to wait @javierprovecho come back.
thinkerou
on 14 Mar 2019
Hello, any update?
visamz
on 15 Mar 2019
Hello, any update?
cugxuan
on 18 Mar 2019
Any update on this?
koderoff
on 26 Mar 2019
@javierprovecho @thinkerou @appleboy I am willing to help push this over the finish line if that is helpful.
dmarkham
on 30 Mar 2019
We all looking forward to this release.
A-limon
on 1 Apr 2019
@thinkerou the vendor/vendor.json versions I don't think are matching up with the go.mod / go.sum files what is your thoughts for dealing with this? Are we dropping support for what ever was using vendor/vendor.json this release?
dmarkham
on 2 Apr 2019
@dmarkham need to update vendor/vendor.json. gin1.4 need to support govendor because go module releases on go1.11.
thinkerou
on 3 Apr 2019
@thinkerou so after taking a stab at getting the govender to match go modules I'm not yet able to to get go1.6 to work. The main reason is we have moved from versionv0.04 -> v0.0.6 of github.com/mattn/go-isatty This package is now using the golang.org/x/sys/unix pacakage that then uses runtime.KeepAlive this is not in go1.6. So This leaves us a few options.
- downgrade
github.com/mattn/go-isatty - drop support for
go1.6andgo1.7in gin1.4.0 - use different versions of
github.com/mattn/go-isattydepending on your choice of dependency manager/go version.
My preference is to drop go1.6 and go1.7 in 1.4.0.
Thoughts?
dmarkham
on 3 Apr 2019
Drop it cloud be a good choice as we're already in go version 1.12.
Lord-Y
on 3 Apr 2019
@thinkerou @appleboy do you guys have any feedback that we can use to move forward on this? or we planning just to hold off and wait for @javierprovecho?
dmarkham
on 6 Apr 2019
Went ahead and merged in the removal of go1.6/go1.7 #1851 in a new pull request as an option for @javierprovecho to review. Also fixing the simple merge conflicts.
dmarkham
on 8 Apr 2019
@thinkerou @appleboy dont think that such a widely used repo should be blocked on merging improvements if @javierprovecho is away
rssathe
on 10 Apr 2019
@thinkerou and me don't have the permission to create new Tag and we must wait for @javierprovecho review all features and bugs.
appleboy
on 10 Apr 2019
so, can you contact with the author?
visamz
on 10 Apr 2019
Yes @visamz Javier has been in contact. He is currently traveling. I do expect things to speed up a bit when he is back. I selfishly would like to have gin a bit more nimble, but it is such a delicate balance between speed and stability.
I have done just a small amount of the grunt work for this release, but I have not setup for a gin release before, so all of the work needs to be checked/verified/corrected and may turn out not be helpful at all!
We already have so many new PR's ready for v1.5.0 killing me to have people waiting to get code merged in or explained why it will be rejected.
v1.4.0 should be here soon enough :100:
dmarkham
on 10 Apr 2019
:wave: Guys, do we have an approximate date when master will be released?
vankofalcon
on 16 Apr 2019
Waiting
awkj
on 18 Apr 2019
still waiting
anasanzari
on 18 Apr 2019
emm... few months later.
LuGHuaaa
on 23 Apr 2019
:disappointed:
dmarkham
on 26 Apr 2019
go.mod feature allows you to specify a specific version, example:
module mymodule
go 1.12
require (
github.com/gin-gonic/gin master
)
This solved the version issue for me, Go 1.11 is required.
goldyfruit
on 29 Apr 2019
@appleboy @thinkerou @javierprovecho Hello Guys! Just a friendly reminder, we are all excited for a new release.
dmarkham
on 2 May 2019
See the new release v1.4.0 https://github.com/gin-gonic/gin/releases/tag/v1.4.0
appleboy
on 8 May 2019
@thinkerou @appleboy Nice job guys I know it was not easy... Lets get rolling on 1.5.0 :+1:
dmarkham
on 8 May 2019
Related issues
mytharcher
路
28Comments
valyala
路
31Comments
dcu
路
30Comments
TaceyWong
路
24Comments
miketonks
路
25Comments
Most helpful comment
Yes @visamz Javier has been in contact. He is currently traveling. I do expect things to speed up a bit when he is back. I selfishly would like to have
gina bit more nimble, but it is such a delicate balance between speed and stability.I have done just a small amount of the grunt work for this release, but I have not setup for a gin release before, so all of the work needs to be checked/verified/corrected and may turn out not be helpful at all!
We already have so many new PR's ready for
v1.5.0killing me to have people waiting to get code merged in or explained why it will be rejected.v1.4.0should be here soon enough :100: