Gin: Upgrade golang version?

[thinkerou]

Now golang have released version 1.10, and gin have not use 1.7 or 1.8 context feature and so on.
We may point out require golang 1.7 and require golang 1.8 period of time.

ref: https://golang.google.cn/doc/devel/release.html#policy

[appleboy]

maybe we can add notes in README?

[thinkerou]

Yes @appleboy and add notes when starting gin, it's my option.

[appleboy]

@thinkerou Could you send the PR? thanks.

[thinkerou]

@appleboy Done, but now only add some readme and debug warn, when we upgrade go version later, we also need update these info.

[bjm88]

I'm on go 1.10.x but still getting this GIN-debug warning GIN-debug] [WARNING] Now Gin requires Go 1.6 or later and Go 1.7 will be required soon . why ???

[thinkerou]

@bjm88 because the warning document [GIN-debug] [WARNING] Now Gin requires Go 1.6 or later and Go 1.7 will be required soon is fixed, it's not independent of your go version. (gin requires go 1.6 or later, but you use go 1.10 now) https://github.com/gin-gonic/gin#prerequisite

[sspaink]

@thinkerou should the warning message not be printed if you are using a version higher then the required? I don't think I understand your comment about the warning being "fixed". Thanks!

I'm using 1.11 at the moment and was confused when I saw the warning thinking gin was somehow using an older version. Other users might run into a similar issue.

[thinkerou]

@bjm88 @BattleBas Hi, on #1572 I add go version judge, please help me review, thanks!

[thinkerou]

Suggestion:

• Maybe gin v1.5.0 no longer support go1.6 and gin v1.6.0 no longer support go1.7.
• And we also need to test gin bench every go version.

[mvolkmann]

I agree with others that this warning message about requiring Go 1.6 or later should not be output when we are running a newer version. I am on 1.12 and still see that warning every time a start a server that uses gin.

[dmarkham]

@appleboy @thinkerou Looks like we need to move on this sooner rather than latter. It looks like all go1.6 builds are now just failing. With go1.12 released and go1.13 getting close. We should be killing off everything less than go1.10!

Somehow in the vender dir has managed to go stale for go1.6 with no code change I can detect. I would spend some time and try to figure it out but we are trying to drop support for it :). I guess this is one way to do it!

github.com/kardianos/govendor/vendor/golang.org/x/sys/unix
../../kardianos/govendor/vendor/golang.org/x/sys/unix/ioctl.go:18: undefined: runtime.KeepAlive
../../kardianos/govendor/vendor/golang.org/x/sys/unix/ioctl.go:28: undefined: runtime.KeepAlive
../../kardianos/govendor/vendor/golang.org/x/sys/unix/syscall_linux.go:100: undefined: runtime.KeepAlive

[thinkerou]

go1.6 builds are now just failing

Yes.

We should be killing off everything less than go1.10!

This is a daring plan. But I think we should only remove go1.6&go1.7 support at gin1.4.x(transition time/version), and gin1.5.x will remove go1.8&go1.9. do you think?

[dmarkham]

Sorry, We should only kill 1.6 & 1.7 until we get go1.4.0 out :)

[thinkerou]

1851 merged!