We should remove the use of Range in image::SubresourceLayers and image::SubresourceRange, and instead pass count of layers/mipmaps as Option<NonZero>. This would correspond to VK_REMAINING_ARRAY_LAYERS and VK_REMAINING_MIP_LEVELS in vulkan. We could also take this opportunity to refine the terms used for fields and comments.
kvark
All 7 comments
Hi, just to let you know I've started working on this :+1:
hgallagher1993
on 5 Apr 2020
@hgallagher1993 I assume the issue is up for grabs again
kvark
on 5 Aug 2020
@kvark I did completely forget about it but I started looking into this again about 2 weeks ago (it's how I found #3319 馃槃), I was using the reftests just to make sure everything was compiling and working so with that fix merged I plan on working on this again today. I mostly have this finished from a couple of months ago so it shouldn't take me too long I don't think.
hgallagher1993
on 5 Aug 2020
Oh that's wonderful news! looking forward to it - this is our last blocker, pretty much.
kvark
on 5 Aug 2020
@hgallagher1993 did you get anywhere with this?
kvark
on 14 Aug 2020
@kvark sorry for the late reply I was traveling to my home country all day yesterday. I had actually pretty much finished this I think but running cargo run --bin quad --features dx12 on Windows leads to 20 compile errors (unrelated to my changes) so before creating the merge request for this I was going to look into fixing them as well just so I could have everything compiling properly
hgallagher1993
on 15 Aug 2020
@kvark created the issue for the compile failures here #3334
hgallagher1993
on 15 Aug 2020
Related issues
kvark
路
4Comments
msiglreith
路
3Comments
Lokathor
路
4Comments
Limeth
路
3Comments
torkleyy
路
4Comments
Most helpful comment
Hi, just to let you know I've started working on this :+1: