Gesturefy: Rocker gesture hardly works

[thany]

Rocker gestures need some love.

They oftenly just simply don't work. Like, at all. Sometimes when they do, they'll still display the context menu. I just have to try the backwards-gesture three or four times before it works.

[Robbendebiene]

Which Firefox version are you using and what is your operating system?

[thany]

Firefox 56 on Windows 10, both x64

[Robbendebiene]

Hm it's working fine for me, maybe you are pressing the mouse buttons too fast so they are not in the right order?

[rodalpho]

For me, unless I very do the rocker gestures very deliberately, it seems like the addon picks whether to do a RL or LR rocker at random.

I have R+L set to "close current tab" and L+R set to "restore closed tab". So it's very disorienting when it messes up.

In its current state, rocker gestures are essentially not usable for me.

[will76]

+1 Does not work all the times. Weird.
Using the FF 57 beta

Edit: Also, it sometimes throws random actions other than the selected one!

[Robbendebiene]

@will76 What actions exactly does it "throw"? and what are your selected actions?

@all I'll need more information how to reproduce it, because it's working just fine for me. Maybe it only happens on certain pages, after a specific amount of clicks, or if a specific action is selected.

[stmr]

For me they work flawlessly. The only thing is that they only work after the page has been loaded, bud that's sadly how WebExtensions work.

[thany]

Perhaps they only work best on ajaxified (I hate that word :)) websites, where each link is not loaded by the browser, but through ajax. Youtube and Github are good examples of this.

Another thing I noticed is the back-gesture oftenly displays the context menu at the end, esp when the gesture ends while the previous page is already about to render.

[SilentSin]

The issue isn't that it picks a direction randomly, it's that it picks the direction based on the side you release first rather than the side you press first.

In Fire Gestures: RMB + LMB = Rocker Left on button down.

In Gesturefy: RMB + LMB = nothing on button down, then go in whichever direction you release first.

I greatly preferred the Fire Gestures way.

[rodalpho]

I just tested it out and when I do a R+L chord I definitely release the left before the right. It's just that if I don't do it slowly and deliberately, it executes the L+R assigned function. And this is actually repeatable. Do it fast, fails. Do it slow, works.

Maybe the _timing_ is the problem, and when I do it quickly it _thinks_ I'm releasing them simultaneously or something, even though I'm definitely not?

[Robbendebiene]

Another thing I noticed is the back-gesture oftenly displays the context menu at the end, esp when the gesture ends while the previous page is already about to render.

Yep, in this state (page loading) it's impossible to do anything including contextmenu suppression.

The issue isn't that it picks a direction randomly, it's that it picks the direction based on the side you release first rather than the side you press first.
In Fire Gestures: RMB + LMB = Rocker Left on button down.
In Gesturefy: RMB + LMB = nothing on button down, then go in whichever direction you release first.
I greatly preferred the Fire Gestures way.

I preferred it too, but I remember some problems with supressing the context menu when using mosuedown. However I'm currently not able to reproduce them.

So here is a version with mousedown which (in theory) should fix most of the problems. Maybe someone can help testing it, because I first implemented it this way and changed it to mouseup due to some problems:

1. disable you current version of gesturefy in the browser
2. download and unzip: https://github.com/Robbendebiene/Gesturefy/archive/rockerOnMouseDown.zip
3. go to "about:debugging" in firefox and click "load addon temporary"
4. choose the manifest.json file in the "src" folder
5. please test different actions like: next tab, reload, history back etc.

That isn't actually the problem for me, I just tested it out and when I do a R+L chord I definitely release the left before the right. It's just that if I don't do it slowly and deliberately, it executes the L+R assigned function. And this is actually repeatable. Do it fast, fails. Do it slow, works.

I'm pretty sure thats the same "issue", because it's intuitv to release the first pressed button when doing it fast. You should consider using this gesture more by holding one button down and then clicking the other mouse button multiple times (instead of "rocking" multiple times). Thats the actual strength.

[stmr]

@SilentSin I can confirm this, and it doesn't matter what the speed is @rodalpho it's just the way it's implemented (onMouseUp)

@thany not 100% sure when do webextensions get activated, but I'm pretty sure that some "ajaxified" pages can draw a basic page layout and process the rest through ajax, so the webextension gets to work a bit faster than on pages that have to draw everything at once so that might be the reason. Should work the same way on all pages if they were loaded when you started to perform the gestures.

@Robbendebiene Thanks! Tried it for a while and haven't come upon any problem and it also feels faster :) (but I've tried only next/previous tab, history back/forward and few reload actions)

[rodalpho]

If the new version fixes it, maybe you're right and the mousedown event is what matters.

I use R+L to close the current tab, so the use case of closing multiple tabs in sequence in the same order is infrequent. But it does happen and I do use it that way too.

[Robbendebiene]

I'm closing this issue since rocker gestures are now triggered on mouseup. If you have any further problems let me know.

[rodalpho]

I can confirm this 100% fixed the problem for me. Thanks again!

[martin-wanderer]

RMB still opens context menu. So RMB+LMB doesn't work, while LMB+RMB works pretty well.
Gesturefy 1.1.17, Firefox 57.0.3, Ubuntu 17.10

[Robbendebiene]

@martin-wanderer Please read the addon description, or the project description, or here.

[martin-wanderer]

Yes, I've already read that.
Does this

MacOS & Linux users can only use the right mouse button using the latest Firefox 58!

concern rocker gestures as well as normal ones?

[Robbendebiene]

@martin-wanderer Yes, everything that requires the right mouse button, because the context menu on MacOS and Linux opens on mouse down (since firefox 58 there is a property to change this)