Generator-jhipster: Remove hard coded path in updateLanguagesInWebpackAngular

Created on 27 Oct 2020  路  4Comments  路  Source: jhipster/generator-jhipster

Overview of the issue

To allow blueprint customization we need to use ${this.CLIENT_MAIN_SRC_DIR} here
https://github.com/jhipster/generator-jhipster/blob/main/generators/generator-base-private.js#L343

Related issues

https://github.com/jhipster/generator-jhipster/pull/12410

Suggest a Fix

I can provide a PR to fix this if you are ok

JHipster Version(s)
JHipster configuration
Entity configuration(s) entityName.json files generated in the .jhipster directory
Browsers and Operating System

  • [x] Checking this box is mandatory (this is just to show you read everything)
area theme

All 4 comments

@nicolas63 Can you provide a PR, please?

@nicolas63 if you are willing to create the PR, always go for it 馃槃 .

To prevent others bugs like this, add

path.join(__dirname, '..', 'generators', 'generator-base-private.js')
path.join(__dirname, '..', 'generators', 'generator-base.js')

and any other file that make sense to
https://github.com/jhipster/generator-jhipster/blob/2302720eb7ed54cf114130559f715904c823af4f/test/enforcements.spec.js#L41-L49

Thanks for your advice @mshima. I will add this test

@nicolas63 please add ...readDir(path.join(__dirname, '..', 'generators', 'entities-client')), too.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

chegola picture chegola  路  4Comments

DanielFran picture DanielFran  路  3Comments

ahmedeldeeb25 picture ahmedeldeeb25  路  3Comments

pascalgrimaud picture pascalgrimaud  路  4Comments

frantzynicolas picture frantzynicolas  路  3Comments