Generator-jhipster: Fix Angular e2e tests so they don't pause for alerts

[mraible]

Overview of the feature request

Currently, running npm run e2e on an Angular app has pauses while it waits for alerts to disappear. On the other hand, if you run npm run e2e on a React app, there is no waiting, and the tests complete much faster.

Motivation for or Use Case

It's fun when the e2e tests really fly by. Not so much when there's pauses like Angular has.

Related issues or PR

No active ones that I know of.

• [x] Checking this box is mandatory (this is just to show you read everything)

[pascalgrimaud]

@mraible : it's because React uses a different style of alert, so it's not consistent with Angular.
Anyway, about Angular, in our CI, we already reduces the e2e:
https://github.com/jhipster/generator-jhipster/blob/master/test-integration/scripts/23-package.sh#L19-L23

I don't know if it's what you're looking for ?

[Falydoor]

I was also thinking of looking for the alert and closing it (which is an upgrade because it will make sure the alert was shown).

[pascalgrimaud]

@Falydoor : indeed, click on the close button would be a solution too ! if we decide to implement this solution, we need to remove the change in the CI

[mraible]

I didn't know the timeout was reduced in CI. That doesn't help me as an end use though. In demos, I still have to wait.

On May 12, 2020, at 07:35, Pascal Grimaud [e-mail] wrote:


@Falydoor : indeed, click on the close button would be a solution too ! if we decide to implement this solution, we need to remove the change in the CI

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

[pascalgrimaud]

I think the best solution would be the one suggested by @Falydoor : click on close

@Falydoor : would you like to have a look and try to implement it ?

[Falydoor]

Yes I will take a look!

[Falydoor]

Closing the alert doesn't really fix the issue because Protractor still wait on the timeout. One way to disable this behavior is by using https://www.protractortest.org/#/api?view=ProtractorBrowser.prototype.waitForAngularEnabled but it breaks the tests that perform http requests.

Maybe there is a way to clear the alert's timeout?

[bagage]

Is that still an open issue? On a newly generated empty project, E2E tests last 10s and it seems alerts are dismissed without waiting timeout?

[Falydoor]

Did you create an entity? I still have the issue:

[mraible]

I can confirm that this is still an issue with the latest release.

$ jhipster --version
6.10.1

[mshima]

I was taking a look if cypress improves this yesterday and it doesn’t.
All frameworks angular/react/vue takes similar time to finish e2e, this is not angular exclusive.
I think this should be fixed at cypress, protractor is kind of deprecated now.
Current branch with cypress:
https://github.com/avdev4j/generator-jhipster/pull/55/

[mshima]

I was digging this further.
I've tried cypress, and it is not affected by this problem.

Protractor waits for every setTimeout (https://www.protractortest.org/#/timeouts).
The offend class is https://github.com/jhipster/ng-jhipster/blob/e5649a40b2fd1daa3ebae56f8f2fa96736415f81/src/service/alert.service.ts#L133-L135.

The workaround is to set alertTimeout to 0 (will disable the alert, or 1 to run setTimeout with 1ms) at
https://github.com/jhipster/generator-jhipster/blob/d3115ea5da697dbacd861eebeaeb0246171f9c49/generators/client/templates/angular/src/main/webapp/app/core/core.module.ts.ejs#L40
Our current CI sets to 1:
https://github.com/jhipster/generator-jhipster/blob/d3115ea5da697dbacd861eebeaeb0246171f9c49/test-integration/scripts/23-package.sh#L19-L23

I've tried to find a way to pass a variable or any way to let angular know it's running inside angular, but I couldn't find a good solution.

Since protractor will be deprecated, I think we should just close this.
An alternative is to add this workaround to the documentation.

[DanielFran]

@mraible @pascalgrimaud Should we continue with this issue opened since we mgrated now by default to cypress?

[pascalgrimaud]

@DanielFran : let's keep this opened for our JHipster Code next week. Then, if it's not fixed, I think we can close it, in favor of Cypress

[mshima]

@Falydoor can you confirm if [email protected] fixes the problem?

[Falydoor]

It does, awesome!