Generator-jhipster: Change Signature of Test Method createUpdatedEntity

[geyuqiu]

Overview of the feature request

delete param entitymanagerin createUpdatedEntitymethod, because it is never used

public static [EntityName] createUpdatedEntity(EntityManager em) {
    // em is never used
}

Motivation for or Use Case

Related issues or PR

no idea

• [x] Checking this box is mandatory (this is just to show you read everything)

[mshima]

@geyuqiu, you could start providing PRs.
Is quite easy.
Ex:

• go to https://github.com/jhipster/generator-jhipster/blob/master/generators/server/templates/src/test/java/package/web/rest/UserResourceIT.java.ejs
• Click on the pencil icon (upper right)
• Edit the file.
• Propose the changes. It will create a new repository/branch on your user and create a PR.

This will really be helpful for changes like this one.
It's a very simple cleanup, but maybe this is kept from backward compatibility, in that case it will be labeled as 7.x.

[SudharakaP]

@geyuqiu : Also just to add to what mshima said, we also have a contribution guidelines document at https://github.com/jhipster/generator-jhipster/blob/master/CONTRIBUTING.md. You will find all the information that is necessary to make contributions to the project there. If you have any doubts feel free to ask in out Gitter Channel; https://gitter.im/jhipster/generator-jhipster 😄

[murdos]

In fact this parameter is used when your entity has required relationships with other entities. And since the templates that generates the code that calls this method can't know it the parameter will be used, it always provides it.

BTW @geyuqiu please provide more context and information when you create issue (jhipster info, JDL used, ...) because it's often an headache to understand what you're talking about. E.g. here you're talking about a method, but don't even say in which class is this method. Because I know this part of the generator, I know that this is in the generated integration test for an entity. But then I would need the .json or the JDL to reproduce what you've observed.

[SudharakaP]

BTW @geyuqiu please provide more context and information when you create issue (jhipster info, JDL used, ...) because it's often an headache to understand what you're talking about. E.g. here you're talking about a method, but don't even say in which class is this method. Because I know this part of the generator, I know that this is in the generated integration test for an entity. But then I would need the .json or the JDL to reproduce what you've observed.

@geyuqiu : Can't agree more on what @murdos said. We are quite happy to incorporate your suggestions but I am also having a hard time understanding what you are proposing sometimes. So please complete the issue/bug templates as much as you could 😄

[pascalgrimaud]

This ticket has been closed as the guidelines are not followed.

Tickets must follow our Guidelines, as mentioned in:

1. our Readme file on the front page of the project,
2. the "create a new ticket" page and
3. our Help page

We have also created a template on the "create a new ticket" page to help you follow those guidelines.

If this is indeed a JHipster bug, please open a new issue with proper details or update this issue with all details and request to reopen.
Issues opened without proper details will be closed without explanation.

If you have a question please use Stack Overflow, and tag the question with jhipster. This helps the project to keep the issue tracker clean. Also, Stack Overflow will give your question a larger audience:

• This will increase your chances to get an answer
• Answers will be of higher quality, as there is a voting system
• This will also help other users who might have the same issue, as questions are tagged and easily searchable