Generator-jhipster: Reuse before() Method in Every Entity

Created on 11 Feb 2020  路  6Comments  路  Source: jhipster/generator-jhipster

Overview of the feature request

export redundant code for signing in to the app

before(async () => {
    await browser.get('/');
    navBarPage = new NavBarPage();
    signInPage = navBarPage.getSignInPage();
    await signInPage.autoSignInUsing('admin', 'admin');
    await browser.wait(ec.visibilityOf(navBarPage.entityMenu), 5000);
});

Motivation for or Use Case
Related issues or PR
  • [x] Checking this box is mandatory (this is just to show you read everything)
area angular

All 6 comments

@geyuqiu : Can you provide some more info on the motivation of the change; Do you mean we have redundant code at entity.spec.ts? I am just trying to understand your issue with this piece of code. 馃槃

yes

actually all entities generated by jdl have this in e2e test inside beforeblock, if protractor enabled

sounds reasonable. @geyuqiu, would you like to create a PR refactoring this code?

@geyuqiu : did you start this ?

This ticket has been closed as the guidelines are not followed.

Tickets must follow our Guidelines, as mentioned in:

  1. our Readme file on the front page of the project,
  2. the "create a new ticket" page and
  3. our Help page

We have also created a template on the "create a new ticket" page to help you follow those guidelines.

If this is indeed a JHipster bug, please open a new issue with proper details or update this issue with all details and request to reopen.
Issues opened without proper details will be closed without explanation.

If you have a question please use Stack Overflow, and tag the question with jhipster. This helps the project to keep the issue tracker clean. Also, Stack Overflow will give your question a larger audience:

  • This will increase your chances to get an answer
  • Answers will be of higher quality, as there is a voting system
  • This will also help other users who might have the same issue, as questions are tagged and easily searchable
Was this page helpful?
0 / 5 - 0 ratings

Related issues

chegola picture chegola  路  4Comments

lsadehaan picture lsadehaan  路  3Comments

ahmedeldeeb25 picture ahmedeldeeb25  路  3Comments

pascalgrimaud picture pascalgrimaud  路  3Comments

RizziCR picture RizziCR  路  3Comments