Generator-jhipster: Update Sonar Analysis Rules According to New Rules

[SudharakaP]

Overview of the issue

Recently SonarQube added some new rules. This effects most projects and right now there's a huge number of new bugs and vulnerabilities detected. We probably need to do minor changes to so that we pass the quality gate analysis.

https://sonarcloud.io/dashboard?id=io.github.jhipster.sample%3Ajhipster-sample-application

• [x] Checking this box is mandatory (this is just to show you read everything)

[SudharakaP]

I can create a pull request for this in the next week or the following; if someone wants to do this sooner feel free to take it. 😄

[atomfrede]

I will take care of a few issues now.

[SudharakaP]

@atomfrede : Wonderful. Thanks a bunch 😄

[amatosg]

regarding Sonar, would it be ok if I fix the bugs shown there?

[SudharakaP]

regarding Sonar, would it be ok if I fix the bugs shown there?

@amaillere : I have no problems; feel free to by all means; I didn't know everyone likes fixing Sonar bugs.... 🤣 🤣 😃 😄

[amatosg]

I do, it improves code quality ;)

[SudharakaP]

@atomfrede : I suppose after merging #10263 we should get A rating and this could be closed; correct? Just confirming to make sure whether I have to work further on this one. :smile:

[atomfrede]

@SudharakaP Yes, I think there are no other issues left.

[SudharakaP]

Wonderful. Thanks for the confirmation. :smile:

On Sat, Aug 31, 2019, 12:01 PM Frederik Hahne [e-mail]
wrote:

@SudharakaP https://github.com/SudharakaP Yes, I think there are no
other issues left.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jhipster/generator-jhipster/issues/10258?email_source=notifications&email_token=AC64D7K6NLYBAYDCELNT6ZDQHK5YFA5CNFSM4IOVVBU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5TTH3A#issuecomment-526857196,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC64D7OR3AFVD4BFEUU2OLTQHK5YFANCNFSM4IOVVBUQ
.

[atomfrede]

I think we can close this as we have only seven issues (which are false positives) left.