Generator-jhipster: Upgrade to JUnit 5

Created on 28 Mar 2019 · 9Comments · Source: jhipster/generator-jhipster

Overview of the feature request

We should upgrade to JUnit 5 because it's the latest and greatest version of JUnit and JHipster is hip!

Motivation for or Use Case

Show Java developers the latest and greatest technologies.

How

For Maven, exclude junit:junit and include junit-jupiter-engine:

<dependency>
    <groupId>org.junit.jupiter</groupId>
    <artifactId>junit-jupiter-engine</artifactId>
    <scope>test</scope>
</dependency>
<dependency>
    <groupId>org.springframework.boot</groupId>
    <artifactId>spring-boot-starter-test</artifactId>
    <scope>test</scope>
    <exclusions>
        <exclusion>
            <groupId>junit</groupId>
            <artifactId>junit</artifactId>
        </exclusion>
    </exclusions>
</dependency>

For Gradle:

testImplementation ("org.springframework.boot:spring-boot-starter-test") {
    exclude module: "junit"
    exclude group: "com.vaadin.external.google", module: "android-json"
}
testImplementation "org.junit.jupiter:junit-jupiter-engine"

In .java files:

Replace org.junit.Before with org.junit.jupiter.api.BeforeEach (or BeforeAll, I'm not sure which)
Replace org.junit.Test with org.junit.jupiter.api.Test
Remove classes and imports no longer needed:
1. import org.junit.runner.RunWith;
2. import org.springframework.test.context.junit4.SpringRunner;
3. @RunWith(SpringRunner.class)

I'm sure there's more, but this seems like the basics to get started.

$100 area java

Source

mraible

👍11

Most helpful comment

I think it's better to do it in one go as users are going to be annoyed to have an app that is partially migrated between JUnit 4 and 5.

PierreBesson on 8 Apr 2019

👍2

All 9 comments

That would be great. I just hope all our test dependencies work with it. For instance I had issues on a project with the EmbeddedKafka. Testcontainers seems to have an extension.