Generator-jhipster: [documentation] Add missing JDL field validation for unique constraint

Created on 26 Sep 2018 · 16Comments · Source: jhipster/generator-jhipster

Overview of the issue

Reviewing JDL documentation I discover that the unique constraint implementation in jhipster-core project has never been documented in JDL documentation.

Motivation for or Use Case

A new feature since v.4.13.0 & v5.0.0.beta2 that seems not documented (https://github.com/jhipster/generator-jhipster/pull/6678 + https://github.com/jhipster/generator-jhipster/pull/6850 + https://github.com/jhipster/generator-jhipster/issues/6860):
https://github.com/jhipster/generator-jhipster/commit/f2e367315ec4128105c72df054079107d1be3279
https://github.com/jhipster/generator-jhipster/commit/baaa043c5564154d879a18e9cb1483745e38d56c

Note: The PR https://github.com/jhipster/jhipster.github.io/pull/520 has been merged in create entity documentation but I think it is missing the documentation in JDL part.

[x] Checking this box is mandatory (this is just to show you read everything)

area area JDL

Source

DanielFran

All 16 comments

@MathieuAA I did not found any reference in https://github.com/jhipster/jhipster.github.io/blob/master/pages/jdl.md.
Do you want I PR to add the information?

Does the issue https://github.com/jhipster/jhipster-core/issues/18 should be closed?

DanielFran on 26 Sep 2018

Is it finally in the generator?! I have a branch already for this... I'll find time to merge it and add the doc

MathieuAA on 26 Sep 2018

I'm not sure, will need to look at code. But I think it wad reverted at
some point due to issues

On Wed, 26 Sep 2018, 7:29 am Mathieu ABOU-AICHI, notifications@github.com
wrote:

Is it finally in the generator?! I have a branch already for this... I'll
find time to merge it and add the doc

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jhipster/generator-jhipster/issues/8403#issuecomment-424589567,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDlF12USQPZiLed37xQgJnv9uYH1kh6ks5uexCggaJpZM4W5jzs
.

deepu105 on 26 Sep 2018

Well, once it's in the generator and enabled, feel free to reach me so that I can do my part. Thanks :)

MathieuAA on 26 Sep 2018

@deepu105 @MathieuAA Confirmed for the 2 pull request on generator side:
Related for this commit https://github.com/jhipster/generator-jhipster/commit/f2e367315ec4128105c72df054079107d1be3279
OK in https://github.com/jhipster/generator-jhipster/blob/master/generators/entity-server/templates/src/main/resources/config/liquibase/changelog/added_entity.xml.ejs:

KO in https://github.com/jhipster/generator-jhipster/blob/master/generators/entity/prompts.js:

https://github.com/jhipster/generator-jhipster/blob/master/generators/entity/prompts.js#L722-L725
(...)
Because it was _Temporarily remove the "unique" option in the questions_ by @jdubois https://github.com/jhipster/generator-jhipster/commit/ad66b9cf8cd534113d63440d58343aef7633bd62

So we need to take care of the missing changes in https://github.com/jhipster/generator-jhipster/blob/master/generators/entity/prompts.js

DanielFran on 28 Sep 2018

Roger that. Thanks for the heads up

MathieuAA on 28 Sep 2018

@jdubois To reactivate prompts for "unique" field validation, can you please re-revert https://github.com/jhipster/generator-jhipster/commit/ad66b9cf8cd534113d63440d58343aef7633bd62 or should I do a PR for this?

DanielFran on 28 Sep 2018

@DanielFran I'm reverting the commit right now

jdubois on 1 Oct 2018

👍1

@MathieuAA I think that you can merge your changes and create the PR for the JDL documentation ;)

DanielFran on 1 Oct 2018

@DanielFran sorry I can't revert the commit easily, there's a conflict, give me some time :-)

jdubois on 1 Oct 2018

@MathieuAA You can proceed with the merge of unique validation in Core project since @jdubois already merge the missing prompts in the generator.
Do not forget to add the documentation in JDL part.
Thanks

DanielFran on 3 Oct 2018

Okay!Le 3 oct. 2018 23:40, Daniel Franco notifications@github.com a écrit :@MathieuAA You can proceed with the merge of unique validation in Core project since @jdubois already merge the missing prompts in the generator.
Do not forget to add the documentation in JDL part.
Thanks

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

MathieuAA on 4 Oct 2018

@MathieuAA Just to confirm with you if you already do the PR for to update of JDL documentation?
This issue is still open waiting for your confirmation....

DanielFran on 12 Oct 2018

I don't have much time nowadays to do anything, but it's merged. I'll do the doc during the weekendLe 12 oct. 2018 18:04, Daniel Franco notifications@github.com a écrit :@MathieuAA Just to confirm with you if you already do the PR for to update of JDL documentation?
This issue is still open waiting for your confirmation....

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

MathieuAA on 12 Oct 2018

👍1

The PR has been submitted.

MathieuAA on 13 Oct 2018

👍1

Closed with https://github.com/jhipster/jhipster.github.io/pull/641

DanielFran on 13 Oct 2018

Was this page helpful?

0 / 5 - 0 ratings