Generator-jhipster: Version 6 of #Angular is now available

[DanielFran]

Version 6 of #Angular is now available! Updates to the framework, CLI, Material, CDK, and more!

https://blog.angular.io/version-6-of-angular-now-available-cc56b0efa7a4

https://blog.ninja-squad.com/2018/05/04/what-is-new-angular-6/

https://books.ninja-squad.com/angular/changelog

Anyone available to work in the migration for Jhispter v5?

[wmarques]

I'll work on that and provide at least a starting point in a day if you guys are ok
Thanks for the links !

[sendilkumarn]

@wmarques go ahead. But a lot of rxjs refactorings will be there

[sendilkumarn]

with ng-bootstrap-2.0.0 out. we can upgrade it

[agoncal]

@wmarques I'll be more than happy to test and give you some feedback.

BTW Angular CLI 6 makes it easy to create libraries (https://github.com/angular/angular-cli/wiki/stories-create-library). We use this "kind" of mecanism to aggregate our Microservices. Maybe something to brainstorm for the future

[Tcharl]

I noticed some jh issues to make angular.cli working with jhipster, for example, the manifest shall be in a .json extension instead of .manifest either way 'ng build' fails.

I'm also thinking of making a material module, as one of our company project's as done the refactoring work (but not on a module), but it's huge to implement during free time: may be if anyone could help, I can share our sources (under NDA) and so we could work on it together.

@wmarques if you need help, I can spend some time on your fork.

@agoncal the library aspect is kind on a must have for us too: ng-packagr was not that easy to configure.

[wmarques]

@sendilkumarn Yep, in fact it's the rxjs part that is taking more time than the Angular parts... I'm submitting a PR with the beginning of my work, I don't think the build will pass for the first time 😢

Here it is #7582

[sendilkumarn]

Just go ahead, Lets do it.

[thainan10]

@wmarques I can help you, if you want.
I've mentioned it few time ago in the gitter.
It think it also worth to change forms with ng model to reactive.

[mraible]

This is the route that I took in Ionic for JHipster. Example: https://github.com/oktadeveloper/generator-jhipster-ionic/blob/master/generators/entity-client/templates/ionic/src/pages/entities/_entity-dialog.ts#L110 https://github.com/oktadeveloper/generator-jhipster-ionic/blob/master/generators/entity-client/templates/ionic/src/pages/entities/_entity-dialog.ts#L110

On May 11, 2018, at 6:18 PM, Thainan Matias da Silva [e-mail] wrote:

@wmarques https://github.com/wmarques I can help you, if you want.
I've mentioned it few time ago in the gitter.
It think it also worth to change forms with ng model to reactive.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/jhipster/generator-jhipster/issues/7575#issuecomment-388515555, or mute the thread https://github.com/notifications/unsubscribe-auth/AABF5J5XtFDpI9OaeC1jlxEHSEZeT8Qzks5txippgaJpZM4TznOF.

[thainan10]

@mraible sure, is with form builder. Angular calls it Reactive Forms.
I know we'll have a lot of effort to change all forms, but I think it worth.
What is the best approach in this case?
Should I create issues to change it and submit pull requests to solve them?

[wmarques]

@thainan10 It's not related with Angular 6 right ? But yes we can do that change, I also prefer the Reactive Form way...
You can submit a new issue or directly submit a PR if you already started working on it.

The thing that is TODO also is to migrate from having services in providers to use the new DI injection syntax in the @Injectable Annotation directly. But I think we should first merge my PR and then migrate the rest

[thainan10]

@wmarques sure. The Reactive Forms initiative is not related to the new Angular version, but I think important, once the new releases are giving the idea ng module will be completely deprecated soon.
I can help you at first to refactor the services to the new model if necessary. I think it won't take so long, because it's just to remove the reference from modules and add it in the services.

[jdubois]

I'm closing this as Angular 6 support has been merged in the master branch - I understand it can be fine-tuned, but those could be other (smaller) tickets for each specific item.