Generator-jhipster: Restrict creating entity with entity name as "Entity"

Created on 14 Jul 2017  路  9Comments  路  Source: jhipster/generator-jhipster

  • Need to restrict the user from able to create an entity with name as "Entity"

eg: yo jhipster:entity Entity

Jhipster Version: v4.6.1

area

All 9 comments

Thanks for the report, would you please consider submitting a pull request against jhipster-core?

https://github.com/jhipster/jhipster-core/blob/8d1e2445dcfa9882fa862b48c35a4f869bcd3acc/lib/core/jhipster/reserved_keywords.js#L40-L46

Hi,

I tried raising a PR, but I got the following error.

remote: Permission to jhipster/jhipster-core.git denied to FirstSamurai.
fatal: unable to access 'https://github.com/jhipster/jhipster-core.git/': The requested URL returned error: 403

This is the first time I am trying to raise a PR for Jhipster.

@FirstSamurai you need to clone the repo and the create PR from your fork please follow https://github.com/jhipster/generator-jhipster/blob/master/CONTRIBUTING.md and https://opensource.guide/how-to-contribute/#opening-a-pull-request

@FirstSamurai yes you need to fork the repository first.
Here is our documentation: https://github.com/jhipster/generator-jhipster/blob/master/CONTRIBUTING.md

@deepu105 we're in sync :-)

@jdubois :smile_cat:

I'm gonna add https://opensource.guide/how-to-contribute/#opening-a-pull-request to our contribution guide. will be useful for beginners

Thanks I have raised a PR. Please let me know if any mistakes.

https://github.com/jhipster/jhipster-core/pull/136

pr merged

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ahmedeldeeb25 picture ahmedeldeeb25  路  3Comments

DanielFran picture DanielFran  路  3Comments

lsadehaan picture lsadehaan  路  3Comments

DanielFran picture DanielFran  路  3Comments

SudharakaP picture SudharakaP  路  3Comments