Generator-jhipster: Numbers in a project name cause Java compilation issues

[mraible]

If I choose 21points as my application base name, there's compilation problems. For example:

:compileJava
/Users/mraible/dev/21-points/src/main/java/org/jhipster/health/21PointsApp.java:27: error: <identifier> expected
public class 21PointsApp {

I'd suggest reverting to the previous behavior, where Application is used. I'll create a PR.

[gmarziou]

Why not fixing the issue by rejecting wrong names? Or defaulting to Application if the name is wrong.

https://stackoverflow.com/questions/13979172/how-to-check-if-the-class-name-is-valid

We just need to implement this in javascript.

[gmarziou]

Simple regexp "[A-Za-z_$]+[a-zA-Z0-9_$]*" would be enough.

[gzsombor]

+1 for regexp :-)

[gmarziou]

Justification for original change: https://github.com/jhipster/generator-jhipster/issues/2868

[sendilkumarn]

Let the app name be anything, why we need to restrict it?
It would be better if we just remove the numbers if it starts with number.

like 21Points -> points or even points21

P.s - Don't feel great about restricting users [personal opinion]

[wmarques]

@sendilkumarn Agree with that but if we rename the app maybe we should inform the user at least, like "21points will be renamed as points21 for class naming, do you agree?"

[sendilkumarn]

💯 that should be the case warning message.

[jdubois]

Naming it "Application" is good to me -> at least it's the name everywhere,
so it helps in automation and in documentation. And as it's in the root
package what it does is quite clear.

Le 28 juil. 2016 10:27 AM, "Sendil Kumar N" [email protected] a
écrit :

💯 that should be the case warning message.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jhipster/generator-jhipster/issues/3889#issuecomment-235832081,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATVo7mhVBCbhbMZ4Y7xSNJh9yCZBCqXks5qaGfzgaJpZM4JV0co
.

[gmarziou]

See my proposed alternative PR to fix the issue while retaining the JHipster 3;x application naming which is very convenient in the context of microservices.