Gekko: Deprecation warning

[asemaniko]

2017-12-18 21:45:21 (INFO): Starting to watch the market: Poloniex ETC/BTC
2017-12-18 21:45:21 (DEBUG): scheduling ticks
2017-12-18 21:45:21 (DEBUG): Requested ETC/BTC trade data from Poloniex ...
2017-12-18 21:45:21 (DEBUG): Processing 275 new trades. From 2017-12-18 18:26:00 UTC to 2017-12-18 18:44:47 UTC. (19 minutes)
Deprecation warning: moment().add(period, number) is deprecated. Please use moment().add(number, period). See http://momentjs.com/guides/#/warnings/add-inverted-param/ for more info.

Deprecation warning create a problem ??

[erasmuswill]

I've looked through the code and I couldn't find any depreciated code.

On Mon, 18 Dec 2017 at 20:55 asemaniko [e-mail] wrote:

2017-12-18 21:45:21 (INFO): Starting to watch the market: Poloniex ETC/BTC
2017-12-18 21:45:21 (DEBUG): scheduling ticks
2017-12-18 21:45:21 (DEBUG): Requested ETC/BTC trade data from Poloniex ...
2017-12-18 21:45:21 (DEBUG): Processing 275 new trades. From 2017-12-18
18:26:00 UTC to 2017-12-18 18:44:47 UTC. (19 minutes)
Deprecation warning: moment().add(period, number) is deprecated. Please
use moment().add(number, period). See
http://momentjs.com/guides/#/warnings/add-inverted-param/ for more info.

Deprecation warning create a problem ??

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/askmike/gekko/issues/1512, or mute the thread
https://github.com/notifications/unsubscribe-auth/APOh-VPHAJuL_riwgRmLFdZaSnK6QRaqks5tBrUdgaJpZM4RF6uo
.

>

Wilhelm Erasmus

www.wilhelm.co.za
www.facebook.com/erasmuswill
www.github.com/erasmuswill
www.twitter.com/erasmuswill
www.about.me/erasmuswill
www.keybase.io/erasmuswill
www.instagram.com/iamwilhelmiii
[image: profile for Wilhelm Erasmus on Stack Exchange, a network of free,
community-driven Q&A sites] http://stackexchange.com/users/3340760

---

Q: Why is this email five sentences or less?

A: http://five.sentenc.es

[greenbigfrog]

What a timing. cmroche just PRd a "fix" 3 hours before you opened this issue #1510
Also: this message doesn't affect gekko at all (at least ATM)

[woehrer12]

I have the have Problem.
The issue #1510 is not help for this Problem

2017-12-18

22:45:48 (DEBUG): Processing 2597 new trades. From 2017-12-18 21:07:08 UTC to 2017-12-18 21:45:45 UTC. (39 minutes)
Deprecation warning: moment().add(period, number) is deprecated. Please use moment().add(number, period). See http://momentjs.com/guides/#/warnings/add-inverted-param/ for more info.
events.js:160
throw er; // Unhandled 'error' event
^

Error: SQLITE_MISUSE: Database is closed
at Error (native)
at Database.

[woehrer12]

When i have this in the config i have no Problems:

config.tradingAdvisor = {
enabled: true,
method: 'DEMA',
candleSize: 1,
historySize: 1,
adapter: 'sqlite'
}

But wenn i change candleSize or historySize example to 60.
Then is the error comming

[cmroche]

I think the bad add was already fixed in the develop branch, I couldn't find any more cases of this in the code, but commit 7a0d7850a8944a56f11d8c6466a8191c437e73cc does make a correction. If you are on stable you can safely ignore the warning for now, it'll be fixed on the next version release. @woehrer12 @asemaniko

The PR that I created is similar, but with subtract, and looks to be the last place in the code.

[cmroche]

@woehrer12 Your issue with the database is not related to the deprecation warning. Please open a new issue and provide the configuration you are using which replicates this. Changing your candle size likely doesn't fix the problem, I suspect it only reduces the frequency. I am trying to hunt down this bug, but have not had success yet reproducing it.

[dmitriz]

I get the same warning every single time.

When running

$ node gekko.js --config sample-config.js 

this warning appears at least twice:

...
2018-01-10 19:45:37 (INFO):     The trading method requests 3 minutes of historic data. Checking availablity..
Deprecation warning: moment().subtract(period, number) is deprecated. Please use moment().subtract(number, period). See http://momentjs.com/guides/#/warnings/add-inverted-param/ for more info.
2018-01-10 19:45:37 (INFO): 
...
2018-01-10 19:45:40 (DEBUG):    Processing 200 new trades. From 2018-01-10 12:40:31 UTC to 2018-01-10 12:45:38 UTC. (5 minutes)
Deprecation warning: moment().add(period, number) is deprecated. Please use moment().add(number, period). See http://momentjs.com/guides/#/warnings/add-inverted-param/ for more info.
2018-01-10 19:45:58 (DEBUG):    Requested BTC/USDT trade data from Poloniex ...
...

I've checked it is "moment": "2.19.3" in package.json.

[dmitriz]

Also the search shows only one occurrence of moment().add in the file leech.js.
However, the warning persists even after removing that line.
So it must be caused by some other usage of moment.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you feel this is very a important issue please reach out the maintainer of this project directly via e-mail: gekko at mvr dot me.