gatsby recipes storybook-ts not working

[mrseanbaines]

Description

The storybook-ts Gatsby recipe doesn't seem to be working. I am getting an error and a neverending installation phase.

It also seems to be messing up when writing to package.json (see image)

Steps to reproduce

npx gatsby new gatsby-storybook-test
cd gatsby-storybook-test
npx gatsby recipes storybook-ts --install

Expected result

No error. The recipe installs and configures correctly

Actual result

Error and neverending installation

Environment

  System:
    OS: macOS 10.15.6
    CPU: (4) x64 Intel(R) Core(TM) i5-7267U CPU @ 3.10GHz
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.15.0 - /usr/local/bin/node
    Yarn: 1.21.1 - ~/.yarn/bin/yarn
    npm: 6.13.4 - /usr/local/bin/npm
  Languages:
    Python: 2.7.16 - /usr/bin/python
  Browsers:
    Chrome: 84.0.4147.125
    Firefox: 79.0
    Safari: 13.1.2
  npmPackages:
    gatsby: ^2.24.41 => 2.24.41 
    gatsby-image: ^2.4.15 => 2.4.15 
    gatsby-plugin-manifest: ^2.4.22 => 2.4.22 
    gatsby-plugin-offline: ^3.2.23 => 3.2.23 
    gatsby-plugin-react-helmet: ^3.3.10 => 3.3.10 
    gatsby-plugin-sharp: ^2.6.26 => 2.6.26 
    gatsby-source-filesystem: ^2.3.24 => 2.3.24 
    gatsby-transformer-sharp: ^2.5.12 => 2.5.12 

[Lutherwaves]

I'm also getting a neverending installation when I run

gatsby recipes storybook-ts --install

I'm experiencing 0 errors when installing packages manually tho.

[laurieontech]

Thanks for the issue! I don't have the fix yet but wanted to let you know that I was able to reproduce it.

My suspicion at the moment is that it has to do with the mix of dev dependencies and regular dependencies. Trying to switch between the two makes it hang. But that's unconfirmed just yet.

[KyleAMathews]

@laurieontech that looks like it's it!

This recipe doesn't ever finish in the same way:

yo

---

<NPMPackage name="foo" />
<NPMPackage name="bar" dependencyType="development" />