Gatsby: chore(www): Use react-icons' discord icon instead of our custom one

Created on 21 Feb 2020  路  3Comments  路  Source: gatsbyjs/gatsby

Description

I don't see why we're using a custom discord icon component instead of the one that react-icons has. I'm guessing we included it before react-icons added it in, but we should be able to switch it out now.

good first issue help wanted website maintenance

Most helpful comment

@tesseralis looking into it. This might be my first contribution to open source! 馃槄

Looks like the Icon is only used in one place.

All 3 comments

@tesseralis looking into it. This might be my first contribution to open source! 馃槄

Looks like the Icon is only used in one place.

@HarryFray go ahead!

I'm guessing we included it before react-icons added it in

Yep! www is still using react-icons v2
https://github.com/gatsbyjs/gatsby/blob/ff5458502473b4f50febc717266ce039ac26a93f/www/package.json#L89
The version of Font Awesome icons it includes didn't have it: https://react-icons.github.io/react-icons/fa.html

but we should be able to switch it out now.

馃挴https://react-icons.netlify.com/#/icons/fa

Was this page helpful?
0 / 5 - 0 ratings

Related issues

totsteps picture totsteps  路  3Comments

Oppenheimer1 picture Oppenheimer1  路  3Comments

dustinhorton picture dustinhorton  路  3Comments

signalwerk picture signalwerk  路  3Comments

kalinchernev picture kalinchernev  路  3Comments