Gatsby: [gatsby-plugin-shopify] Remove undocumented ProductType query

Created on 2 Aug 2019  路  7Comments  路  Source: gatsbyjs/gatsby

This would be a breaking change, but Shopify's GraphQL API no longer documents the ProductType type and the query for product types has started timing out. The product type data is still available via the product query, so we don't lose any data by removing this.

Recommendation:

  1. Remove the PRODUCT_TYPE query in gatsby-source-shopify

    • Remove the query itself (here) and any code that uses it

  2. Remove the ProductType node (here) an all the code that relies on it

NOTE: This will be a breaking change for the plugin!

As a bonus: some of the queries are deprecated in this plugin. This is not an issue, strictly speaking, but refactoring to use the up-to-date queries will help us stay inline with Shopify's API and docs.

This could be a great way for someone new to Gatsby to get a first PR in!

good first issue help wanted

Most helpful comment

Published in [email protected] thanks to @mimibar 馃

All 7 comments

I'll take a look at it. I just started using Gatsby this week.

Is this assigned? I think I have identified the changes needed.

It's not, would you like to take this one on @mimibar?

Thanks, @jlengstorf! This helped me get past the build issue.

Is issue still open?

Yeah, just pending the merge of #16320 @Aswinpookkatt

Published in [email protected] thanks to @mimibar 馃

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ferMartz picture ferMartz  路  3Comments

rossPatton picture rossPatton  路  3Comments

Oppenheimer1 picture Oppenheimer1  路  3Comments

dustinhorton picture dustinhorton  路  3Comments

jimfilippou picture jimfilippou  路  3Comments