Gatsby: Add Loki to npm test script

Created on 10 Feb 2019  路  7Comments  路  Source: gatsbyjs/gatsby

Now that we are testing with Loki in CI, should we also adjust the npm jest script (or add a jest:loki script?)

maintenance

Most helpful comment

Good question. For the most part this doesn't matter for 99% of contributors because they don't touch code related to nodes data store / sorting and filtering nodes when querying (things that are different when using loki), so maybe we could add this as connivence script (jest:loki), but don't run it when running regular jest?

All 7 comments

Good question. For the most part this doesn't matter for 99% of contributors because they don't touch code related to nodes data store / sorting and filtering nodes when querying (things that are different when using loki), so maybe we could add this as connivence script (jest:loki), but don't run it when running regular jest?

how do we feel about running jest:loki in ci when gatsby-core changes?

We can always add more concurrency correct if builds are getting slow?

how do we feel about running jest:loki in ci when gatsby-core changes?

I like this idea 馃憤

Oh I misread - we already run the Loki tests in CI

@m-allanson do we? I don't think so :blush:

@wardpeet we do: https://github.com/gatsbyjs/gatsby/blob/master/.circleci/config.yml#L58-L59 it just wasn't worth to add another check, so it was added as step to unit tests (it adds ~30 secs to test time)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

benstr picture benstr  路  3Comments

magicly picture magicly  路  3Comments

jimfilippou picture jimfilippou  路  3Comments

Oppenheimer1 picture Oppenheimer1  路  3Comments

mikestopcontinues picture mikestopcontinues  路  3Comments