Gatsby: Babel errors shouldn't let the site run

[gaearon]

I'm in a hurry, feel free to close if I'm not following the template.

I have some Babel errors:

But the site still loads in DEV. I guess it just serves the previous version.

This is very wrong and can lead to nightmare-ish debugging sessions. If there is a Babel error, refresh should show that error immediately. Not serve the previous version.

[sidharthachatterjee]

Thank you for reporting this @gaearon

Posting reproduction steps here for future reference

• Clone https://github.com/sidharthachatterjee/gatsby-babel-test
• gatsby develop
• Uncomment line 33 in src/components/image.js
• Develop logs Babel error and error component is rendered in browser
• Hit refresh

Error component is not rendered and previous build is served instead

[gagandeepp]

@sidharthachatterjee can i look into this?

[sidharthachatterjee]

@gagandeepp Sure! Please comment if you need any help 🙂

[gatsbot[bot]]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

[theajr]

@sidharthachatterjee @LekoArts

So far, I found that we are not enforcing webpack rules on js/jsx file.
We can do that in packages/gatsby-plugin-preact/src/gatsby-node.js file by adding below rule under module.rules

{
  test: /\.jsx?$/,
  enforce: "pre",
  loader: "babel-loader"
}

Or is there any other generic place to add such enforcing rules? Please let me know your thoughts.

I would like to work on this. Can you please assign it me?

[krvajal]

@theajr are you still working on this, otherwise I would like to give it a try to make a fix. I am having this issue and it is quite annoying.

[bilogic]

adding below rule under module.rules

{
  test: /\.jsx?$/,
  enforce: "pre",
  loader: "babel-loader"
}

@theajr what about react? I tried the above in my project's gatsby-node.js and it doesn't make any difference, the previous version continues to load.

[github-actions[bot]]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[LekoArts]

This is still up for grabs if someone wants to contribute to Gatsby.

[github-actions[bot]]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[blainekasten]

I just tested this. If a babel syntax error happens, we show the error on the screen immediately. We are not rendering the previous version of the page. I'm going to close this because I believe the original issue is fixed.